Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ipsets with family inet6 in an ipv6-only cluster #68436

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

uablrek
Copy link
Contributor

@uablrek uablrek commented Sep 8, 2018

What this PR does / why we need it:

This PR maked ipsets to be created with family inet6 in an ipv6-only cluster.

Without this PR ipsets are created for ipv4 and attempts to insert ipv6 addresses fails. Most traffic is lost, but not all. Failing syncs also floods the logs.

Which issue(s) this PR fixes

Fixes #67799

Special notes for your reviewer:

There was a isIPv6 flag in the ipsetInfo structure. That field is no longer used and is removed.

It looks like a reason for the flag is that ipsets that is not of hash type does not have the family attribute. However that is checked here. See also #68338

Release note:

Corrected family type (inet6) for ipsets in ipv6-only clusters

Ipsets are now created with "family inet6" in an ipv6-only
cluster.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 8, 2018
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 8, 2018
@uablrek
Copy link
Contributor Author

uablrek commented Sep 9, 2018

Sorry about the delayed CLA. The corporation CLA shall be ready Monday I have been assured.

@uablrek
Copy link
Contributor Author

uablrek commented Sep 12, 2018

CLA should be signed now

@uablrek
Copy link
Contributor Author

uablrek commented Sep 15, 2018

Another CLA attempt...

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 15, 2018
@m1093782566
Copy link
Contributor

/ok-to-test

/cc @islinwb

for review.

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 15, 2018
@islinwb
Copy link
Contributor

islinwb commented Sep 15, 2018

Thanks @uablrek
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2018
@nikhita
Copy link
Member

nikhita commented Sep 25, 2018

/kind bug

/assign @m1093782566
for approval

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 25, 2018
@nikhita
Copy link
Member

nikhita commented Sep 29, 2018

/retest

@uablrek
Copy link
Contributor Author

uablrek commented Oct 19, 2018

Any news on when this can be merged?

@uablrek
Copy link
Contributor Author

uablrek commented Oct 24, 2018

Can you please merge this PR in the 1.13 release? @nikhita @m1093782566

@m1093782566
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1093782566, uablrek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2018
@m1093782566
Copy link
Contributor

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3b5d2e8 into kubernetes:master Oct 24, 2018
@uablrek uablrek deleted the issue-67799 branch April 29, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ipsets have family inet in an ipv6-only cluster for proxy-mode=ipvs
5 participants