-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ipsets with family inet6 in an ipv6-only cluster #68436
Conversation
Ipsets are now created with "family inet6" in an ipv6-only cluster.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sorry about the delayed CLA. The corporation CLA shall be ready Monday I have been assured. |
CLA should be signed now |
Another CLA attempt... |
/ok-to-test /cc @islinwb for review. |
Thanks @uablrek |
/kind bug /assign @m1093782566 |
/retest |
Any news on when this can be merged? |
Can you please merge this PR in the 1.13 release? @nikhita @m1093782566 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: m1093782566, uablrek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.13 |
What this PR does / why we need it:
This PR maked ipsets to be created with
family inet6
in an ipv6-only cluster.Without this PR ipsets are created for ipv4 and attempts to insert ipv6 addresses fails. Most traffic is lost, but not all. Failing syncs also floods the logs.
Which issue(s) this PR fixes
Fixes #67799
Special notes for your reviewer:
There was a
isIPv6
flag in theipsetInfo
structure. That field is no longer used and is removed.It looks like a reason for the flag is that ipsets that is not of
hash
type does not have thefamily
attribute. However that is checked here. See also #68338Release note: