New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ipsets with family inet6 in an ipv6-only cluster #68436

Merged
merged 1 commit into from Oct 24, 2018

Conversation

@uablrek
Contributor

uablrek commented Sep 8, 2018

What this PR does / why we need it:

This PR maked ipsets to be created with family inet6 in an ipv6-only cluster.

Without this PR ipsets are created for ipv4 and attempts to insert ipv6 addresses fails. Most traffic is lost, but not all. Failing syncs also floods the logs.

Which issue(s) this PR fixes

Fixes #67799

Special notes for your reviewer:

There was a isIPv6 flag in the ipsetInfo structure. That field is no longer used and is removed.

It looks like a reason for the flag is that ipsets that is not of hash type does not have the family attribute. However that is checked here. See also #68338

Release note:

Corrected family type (inet6) for ipsets in ipv6-only clusters
Fix for #67799
Ipsets are now created with "family inet6" in an ipv6-only
cluster.
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Sep 8, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@uablrek

This comment has been minimized.

Contributor

uablrek commented Sep 9, 2018

Sorry about the delayed CLA. The corporation CLA shall be ready Monday I have been assured.

@uablrek

This comment has been minimized.

Contributor

uablrek commented Sep 12, 2018

CLA should be signed now

@uablrek

This comment has been minimized.

Contributor

uablrek commented Sep 15, 2018

Another CLA attempt...

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Sep 15, 2018

/ok-to-test

/cc @islinwb

for review.

@k8s-ci-robot k8s-ci-robot requested a review from islinwb Sep 15, 2018

@islinwb

This comment has been minimized.

Member

islinwb commented Sep 15, 2018

Thanks @uablrek
/lgtm

@nikhita

This comment has been minimized.

Member

nikhita commented Sep 25, 2018

/kind bug

/assign @m1093782566
for approval

@nikhita

This comment has been minimized.

Member

nikhita commented Sep 29, 2018

/retest

@uablrek

This comment has been minimized.

Contributor

uablrek commented Oct 19, 2018

Any news on when this can be merged?

@uablrek

This comment has been minimized.

Contributor

uablrek commented Oct 24, 2018

Can you please merge this PR in the 1.13 release? @nikhita @m1093782566

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Oct 24, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 24, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1093782566, uablrek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Oct 24, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 24, 2018

@k8s-ci-robot k8s-ci-robot merged commit 3b5d2e8 into kubernetes:master Oct 24, 2018

18 of 19 checks passed

Submit Queue Milestone is for a future release and cannot be merged
Details
cla/linuxfoundation uablrek authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment