-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: add mandatory configuration to "phase preflight" #68446
kubeadm: add mandatory configuration to "phase preflight" #68446
Conversation
@neolit123: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neolit123 many thanks for this quick fix
LGTM
/assign @timothysc
for adding required labels/milestone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
It generally lgtm but I'd like at @fabriziopandini to dbl-check for final lgtm.
err = configutil.VerifyAPIServerBindAddress(internalcfg.APIEndpoint.AdvertiseAddress) | ||
kubeadmutil.CheckErr(err) | ||
|
||
err = preflight.RunInitMasterChecks(utilsexec.New(), internalcfg, ignorePreflightErrorsSet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neolit123 not blocking, but could you kindly add fmt.Println("[preflight] running pre-flight checks")
+ eventually a pre-flight checks passed
after the error check?
This will provide a better UX (now the user doesn't gets any message in case all the checks are passing).
same for nodes
Add the: - mandatory flag "--config" to the preflight phase and parse the specified config file for either "master" or "node". - flag "--ignore-preflight-errors" to the preflight phase to allow skipping errors. - the function AddIgnorePreflightErrorsFlag() to "options/generic.go", because the flag is used in multiple commands.
44a58ec
to
57fc804
Compare
@fabriziopandini i have added the |
@neolit123 thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, neolit123, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What this PR does / why we need it:
Add the:
and parse the specified config file for either "master" or "node".
allow skipping errors.
to "options/generic.go", because the flag is used in multiple commands.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes kubernetes/kubeadm#924
Special notes for your reviewer:
this is following:
kubernetes/kubeadm#924 (comment)
Release note:
@kubernetes/sig-cluster-lifecycle-pr-reviews
/assign @fabriziopandini
/milestone 1.12
/kind bug