Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Code-gen: Remove lowercasing for project imports #68484
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
I was not sure where or if there are tests for this section of code. Would be happy to add tests if you can point me in the right direction.
If you run the
Sep 10, 2018
referenced this pull request
Sep 11, 2018
@caesarxuchao I was able to pass the tests with a few updates.
I started to add an example of the Uppercasing in _examples like the previous PR. The generation works as expected (I haven't commited this yet).
But during that further testing I notice that the verify tests don't actually run the smoke tests in the verify script. From the test output of this PR:
but now I get the error:
Since the smoke tests have not been running it seems this has been an issue before this PR as you can see on this file in master. Looking at the vendor folder it seems that the all those packages are symlinked back into the main
Thoughts on how to proceed? I could check in the samples folder with the Uppercase as an example, get this merged and closed, then open a separate bug for the re-enabling the smoke tests and fixing the generating of the autoscaling package? What do you think?
Can you add a test demonstrating the client-gen works for camelcased path now?
I added an example with MixedCase. Also needed to update the verify script to build the packages correctly as stated in my previous comment.
Once the example projects were building properly, this uncovered a bug in the code generation for the sub resource
I fixed this in the
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing