New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package fixes for enabling br_netfilter & ip_forward with kubeadm #68624
Conversation
/assign @mikedanese |
/sig cluster-lifecycle |
/kind bug |
@sysrich - Just an FYI but these are not the canonical rpms/debs for the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is divergent from the actual release repo, however they have been slowly drifting apart.
I wonder if we need a discussion about the future of maintaining these bazel builds.
That being said, if you're using bazel artifacts, these are good changes.
5cd95be
to
5a302f5
Compare
Can we give the conf files more intuitive names? |
/test pull-kubernetes-verify |
@mikedanese what would you consider as more intuitive? I followed the naming convention you typically see in the folders in question, in the case of modules-load.d you typically see the conf file named after the "reason this config file exists". In sysctl.d you typically see the conf file named similarly, with a priority version in front of it, with 50- being typical for things provided by distribution packages That said, I get the names look weird outside of the context of the installed system. Which is a route I'd be perfectly happy to submit - will be less simple and straightforward than the current specfiles and their implicit |
I like this, although strictly speaking, this should probably be done by the CRI packages (Docker does it for instance). /area kubeadm |
Whatever is reasonable. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikedanese, sysrich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
For any rpm distribution using our reference .spec files it will include the appropriate configuration to probe the br_netfilter module automatically and enable IP forwarding.
These are mandatory by kubeadm (it fails fatally if this is not configured), but only the Docker CRI runtime satisfies this requirement automatically.
As they're mandatory in kubeadm, they can and should be configured automatically as part of the installation of kubeadm. This will improve kubeadms support for any CRI runtime besides Docker (eg. CRI-O)
The is the upstream aligned variation of openSUSE's equivalent changes here: https://build.opensuse.org/package/rdiff/devel:kubic/kubernetes?linkrev=base&rev=9
Which issue(s) this PR fixes
Fixes kubernetes/kubeadm#1062
Release note: