New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds dynamic lister #68748

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
4 participants
@p0lyn0mial
Contributor

p0lyn0mial commented Sep 17, 2018

What this PR does / why we need it: creates a dynamic lister that returns runtime.Unstructured objects.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

creates a dynamic lister that returns `runtime.Unstructured` objects. The new lister is under `client-go/dynamic/dynamiclister`.

@p0lyn0mial

This comment has been minimized.

Show comment
Hide comment
@p0lyn0mial

p0lyn0mial Sep 17, 2018

Contributor

/assign @deads2k

Contributor

p0lyn0mial commented Sep 17, 2018

/assign @deads2k

@p0lyn0mial

This comment has been minimized.

Show comment
Hide comment
@p0lyn0mial

p0lyn0mial Sep 17, 2018

Contributor

@deads2k this pull brings a dynamic lister that returns runtime.Unstructured objects. I hope this is something you have been asking for.

@deads2k I'm working on creating a dynamic informer that will use the dynamic lister.

Contributor

p0lyn0mial commented Sep 17, 2018

@deads2k this pull brings a dynamic lister that returns runtime.Unstructured objects. I hope this is something you have been asking for.

@deads2k I'm working on creating a dynamic informer that will use the dynamic lister.

@wenjiaswe

This comment has been minimized.

Show comment
Hide comment
@wenjiaswe

wenjiaswe Sep 17, 2018

Contributor

/cc @jpbetz

Contributor

wenjiaswe commented Sep 17, 2018

/cc @jpbetz

@k8s-ci-robot k8s-ci-robot requested a review from jpbetz Sep 17, 2018

@deads2k

This comment has been minimized.

Show comment
Hide comment
@deads2k

deads2k Sep 19, 2018

Contributor

This looks like a solid start. A few comments. @p0lyn0mial Once they are fixed, any particular reason to avoid merging it?

Contributor

deads2k commented Sep 19, 2018

This looks like a solid start. A few comments. @p0lyn0mial Once they are fixed, any particular reason to avoid merging it?

@p0lyn0mial

This comment has been minimized.

Show comment
Hide comment
@p0lyn0mial

p0lyn0mial Sep 19, 2018

Contributor

@p0lyn0mial Once they are fixed, any particular reason to avoid merging it?

sgtm, originally I wanted to add the informer too but I can prepare a separate pull for it.

Contributor

p0lyn0mial commented Sep 19, 2018

@p0lyn0mial Once they are fixed, any particular reason to avoid merging it?

sgtm, originally I wanted to add the informer too but I can prepare a separate pull for it.

@deads2k

This comment has been minimized.

Show comment
Hide comment
@deads2k

deads2k Sep 20, 2018

Contributor

Looks like you need to regenerate bazel. Then squash down.

/lgtm
/hold

holding so the bot doesn't endlessly retest on bad bazel. Remove the hold after you update bazel.

Contributor

deads2k commented Sep 20, 2018

Looks like you need to regenerate bazel. Then squash down.

/lgtm
/hold

holding so the bot doesn't endlessly retest on bad bazel. Remove the hold after you update bazel.

@p0lyn0mial p0lyn0mial changed the title from [WIP] adds dynamic lister to adds dynamic lister Sep 20, 2018

@p0lyn0mial

This comment has been minimized.

Show comment
Hide comment
@p0lyn0mial

p0lyn0mial Sep 20, 2018

Contributor

/hold cancel

Contributor

p0lyn0mial commented Sep 20, 2018

/hold cancel

@deads2k

This comment has been minimized.

Show comment
Hide comment
@deads2k

deads2k Sep 20, 2018

Contributor

/lgtm

Contributor

deads2k commented Sep 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 20, 2018

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 20, 2018

@p0lyn0mial

This comment has been minimized.

Show comment
Hide comment
@p0lyn0mial

p0lyn0mial Sep 21, 2018

Contributor

New changes are detected. LGTM label has been removed.

go fmt update

Contributor

p0lyn0mial commented Sep 21, 2018

New changes are detected. LGTM label has been removed.

go fmt update

@p0lyn0mial

This comment has been minimized.

Show comment
Hide comment
@p0lyn0mial

p0lyn0mial Sep 21, 2018

Contributor

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-device-plugin-gpu

Contributor

p0lyn0mial commented Sep 21, 2018

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-device-plugin-gpu

@p0lyn0mial

This comment has been minimized.

Show comment
Hide comment
@p0lyn0mial

p0lyn0mial Sep 25, 2018

Contributor

@deads2k please retag the pull.

Contributor

p0lyn0mial commented Sep 25, 2018

@deads2k please retag the pull.

@deads2k

This comment has been minimized.

Show comment
Hide comment
@deads2k

deads2k Sep 26, 2018

Contributor

/lgtm

Contributor

deads2k commented Sep 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 26, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 26, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@p0lyn0mial

This comment has been minimized.

Show comment
Hide comment
@p0lyn0mial

p0lyn0mial Sep 26, 2018

Contributor

/kind feature

Contributor

p0lyn0mial commented Sep 26, 2018

/kind feature

@p0lyn0mial

This comment has been minimized.

Show comment
Hide comment
@p0lyn0mial

p0lyn0mial Sep 26, 2018

Contributor

/retest

Contributor

p0lyn0mial commented Sep 26, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 23baf57 into kubernetes:master Sep 26, 2018

18 checks passed

cla/linuxfoundation p0lyn0mial authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment