New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start synchronizing pods after network is ready. #68752

Merged
merged 1 commit into from Sep 26, 2018

Conversation

@krzysztof-jastrzebski
Contributor

krzysztof-jastrzebski commented Sep 17, 2018

What this PR does / why we need it:
Start synchronizing pods after network is ready. If pod is synchronized before network is ready then it fails and kubelet tries to synchronize pod after 10 seconds.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68751

Release note:

Start synchronizing pods after network is ready. 
@krzysztof-jastrzebski

This comment has been minimized.

Show comment
Hide comment
@krzysztof-jastrzebski
Contributor

krzysztof-jastrzebski commented Sep 17, 2018

/assign @yujuhong

@krzysztof-jastrzebski

This comment has been minimized.

Show comment
Hide comment
@krzysztof-jastrzebski

krzysztof-jastrzebski Sep 17, 2018

Contributor

/assign mwielgus

Contributor

krzysztof-jastrzebski commented Sep 17, 2018

/assign mwielgus

@yujuhong

We intentionally allow pods to start syncing because pods using host network should be able to run (and they often are required to set up the pod networks).
If you want to avoid hitting the backoff error, perhaps you'll need to add a check in the per-pod sync routine to skip the rest of the work (and not incur penalty) when the network is not ready and the pod does not use the host network.

@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Sep 17, 2018

Member

/kind bug

Member

neolit123 commented Sep 17, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug and removed needs-kind labels Sep 17, 2018

@losipiuk

This comment has been minimized.

Show comment
Hide comment
@losipiuk

losipiuk Sep 19, 2018

Contributor

/ok-to-test

Contributor

losipiuk commented Sep 19, 2018

/ok-to-test

Show outdated Hide outdated pkg/kubelet/pod_workers.go
Show outdated Hide outdated pkg/kubelet/pod_workers.go

@k8s-ci-robot k8s-ci-robot added size/M and removed size/XS labels Sep 21, 2018

@krzysztof-jastrzebski

This comment has been minimized.

Show comment
Hide comment
@krzysztof-jastrzebski

krzysztof-jastrzebski Sep 21, 2018

Contributor

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-device-plugin-gpu

Contributor

krzysztof-jastrzebski commented Sep 21, 2018

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce-device-plugin-gpu

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 21, 2018

@yujuhong

/lgtm

A unit test will be good, but I didn't find any existing test for this specific part of the code. Given the small scope of this PR, I think it's okay to let it in.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 21, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzysztof-jastrzebski, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzysztof-jastrzebski, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krzysztof-jastrzebski

This comment has been minimized.

Show comment
Hide comment
@krzysztof-jastrzebski

krzysztof-jastrzebski Sep 26, 2018

Contributor

/test pull-kubernetes-integration

Contributor

krzysztof-jastrzebski commented Sep 26, 2018

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 4404cda into kubernetes:master Sep 26, 2018

18 checks passed

cla/linuxfoundation krzysztof-jastrzebski authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment