Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom metrics conversion functions #68795

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Update custom metrics conversion functions #68795

merged 1 commit into from
Sep 19, 2018

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Sep 18, 2018

What this PR does / why we need it:
Conversions were missed in the ongoing fixes for updates to hpa custom metrics features added in #64097

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #68011

Special notes for your reviewer:
Urgent blocker/regression

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 18, 2018
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 18, 2018
@damemi damemi mentioned this pull request Sep 18, 2018
Closed
@damemi
Copy link
Contributor Author

damemi commented Sep 18, 2018

/cc @losipiuk

@neolit123
Copy link
Member

neolit123 commented Sep 19, 2018 •
edited
Loading

@damemi
please add a release not explaining the change. thanks!

/kind bug
/priority critical-urgent
/sig autoscaling

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 19, 2018
@neolit123
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 19, 2018
@tpepper
Copy link
Member

tpepper commented Sep 19, 2018

/assign @DirectXMan12
any chance you can triage this and let us know if you think it's a release blocker?

@guineveresaenger
Copy link
Contributor

/milestone v1.12
/cc @tpepper
This seems very urgent. Thank you for your immediate attention!

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 19, 2018
@DirectXMan12
Copy link
Contributor

Based on my quick read-though, I think it looks like it. Please ping me on slack this week if there's anything else -- I'm in meetings all week, so I'll be checking github a bit less than normal.

@DirectXMan12
Copy link
Contributor

/approve

This has been tested, correct?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2018
@losipiuk
Copy link
Contributor

Looks good. Some automatic tests would be nice to have though.

@damemi
Copy link
Contributor Author

damemi commented Sep 19, 2018

/retest

also, since this is just a regression fix for a feature that was added this release, it shouldn't need a release note right?

@tpepper
Copy link
Member

tpepper commented Sep 19, 2018

/retest

@damemi
Copy link
Contributor Author

damemi commented Sep 19, 2018

Could someone please mark this /lgtm?

@neolit123
Copy link
Member

@losipiuk

Looks good. Some automatic tests would be nice to have though.

i guess @losipiuk 's point here is that this might be missing unit tests?

@damemi

also, since this is just a regression fix for a feature that was added this release, it shouldn't need a release note right?

no, release note is not needed in that case.

@damemi
Copy link
Contributor Author

damemi commented Sep 19, 2018

@neolit123 @losipiuk we actually have e2e tests currently in the works in a separate PR (#62351). Those have been delayed by some confusion on providing an adapter image and the changes related to this PR but should hopefully be landing soon

@neolit123
Copy link
Member

@damemi
ACK, leaving the LGTM to sig-autoscalling folks.

@DirectXMan12
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cdadc11 into kubernetes:master Sep 19, 2018
@damemi damemi mentioned this pull request May 30, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@nikhiljindal nikhiljindal Awaiting requested review from nikhiljindal

@losipiuk losipiuk Awaiting requested review from losipiuk

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@DirectXMan12 DirectXMan12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

HPA no longer works with adapters exposing Custom Metrics v1beta1 API
7 participants
@damemi @neolit123 @tpepper @guineveresaenger @DirectXMan12 @losipiuk @k8s-ci-robot