Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract cpu requests to separate env variables. #68823

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
4 participants
@loburm
Copy link
Contributor

loburm commented Sep 19, 2018

This PR doesn't change current behavior of cluster, but introduces functionality that allow to control cpu requests of kube-controller-manager and kube-scheduler via environment variables.

[GCP] Added env variables to control CPU requests of kube-controller-manager and kube-scheduler.
@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Sep 19, 2018

/lgtm

@loburm

This comment has been minimized.

Copy link
Contributor Author

loburm commented Sep 19, 2018

/retest

k8s-ci-robot added a commit that referenced this pull request Sep 24, 2018

Merge pull request #68825 from loburm/automated-cherry-pick-of-#68823…
…-upstream-release-1.11

Automated cherry pick of #68823: Extract cpu requests to separate env variables.
@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Sep 25, 2018

/kind feature

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Oct 1, 2018

@loburm please rebase

@loburm loburm force-pushed the loburm:use_env_var_master branch from c3efb1d to 5a118f9 Oct 2, 2018

@loburm

This comment has been minimized.

Copy link
Contributor Author

loburm commented Oct 2, 2018

@wojtek-t done, PTAL.

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Oct 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 2, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: loburm, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7c40095 into kubernetes:master Oct 2, 2018

17 of 18 checks passed

pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation loburm authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

k8s-ci-robot added a commit that referenced this pull request Oct 4, 2018

Merge pull request #69320 from loburm/automated-cherry-pick-of-#68823…
…-upstream-release-1.12

Automated cherry pick of #68823: Extract cpu requests to separate env variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.