extract volume attachment status checking operation as a common function when attaching a CSI volume #68931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion when attaching a CSI volume
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/storage
|
/assign @jsafrane |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, mlmhl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
|
/retest |
|
/retest
…On Sun, Sep 30, 2018 at 3:32 AM k8s-ci-robot ***@***.***> wrote:
@mlmhl <https://github.com/mlmhl>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-integration 2ff6b7e
<2ff6b7e>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/68931/pull-kubernetes-integration/29287/> /test
pull-kubernetes-integration
Full PR test history <https://k8s-gubernator.appspot.com/pr/68931>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/mlmhl>. Please help
us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#68931 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0GEnL0UQtdjeVh0xLBrfthXuhMZmks5uf-4KgaJpZM4W0AIt>
.
|
|
/retest
…On Sun, Sep 30, 2018 at 3:51 AM k8s-ci-robot ***@***.***> wrote:
@mlmhl <https://github.com/mlmhl>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-integration 2ff6b7e
<2ff6b7e>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/68931/pull-kubernetes-integration/29291/> /test
pull-kubernetes-integration
Full PR test history <https://k8s-gubernator.appspot.com/pr/68931>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/mlmhl>. Please help
us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#68931 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0Dwfifv_vZDIM4qtHpi6TDxNzSiJks5uf_JjgaJpZM4W0AIt>
.
|
|
/retest Review the full test history for this PR. Silence the bot with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently CSI volume's
Attachoperation will wait forVolumeAttachment's status changes. In detail, it will:VolumeAttachmentobject first and check its statusVolumeAttachment's status changes and check its status periodicallyThe state checking operation in these two steps is exactly the same, so I prefer to extract this operation as a common function, this makes the code easier to read and maintain.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: