Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep backward compatibility for 'node.Spec.Unschedulable'. #69047

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Keep backward compatibility for 'node.Spec.Unschedulable'. #69047

merged 1 commit into from
Sep 25, 2018

Conversation

tpepper
Copy link
Member

@tpepper tpepper commented Sep 25, 2018

Manual cherry pick of k82cn@78f6484, which is merging to master to address #68899, but is delayed in tide. The original commit is release-1.12 approved and release blocking.

Signed-off-by: Tim Pepper tpepper@vmware.com

@k82cn
Keep backward compatibility for 'node.Spec.Unschedulable'.
816a9e1 
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
@tpepper
Copy link
Member Author

tpepper commented Sep 25, 2018

/assign @dougm
/cc @k82cn
/priority critical-urgent
/sig node
/sig scheduling

@tpepper tpepper added this to the v1.12 milestone Sep 25, 2018
@tpepper
Copy link
Member Author

tpepper commented Sep 25, 2018

/cc @cblecker

@tpepper tpepper added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/node Categorizes an issue or PR as relevant to SIG Node. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Sep 25, 2018
@cblecker
Copy link
Member

/test all

dougm
dougm reviewed Sep 25, 2018
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2018
@tpepper
Copy link
Member Author

tpepper commented Sep 25, 2018

/cc @k82cn

@dougm
Copy link
Member

dougm commented Sep 25, 2018

/test pull-kubernetes-integration

@cblecker
Copy link
Member

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 25, 2018
@dougm dougm added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 25, 2018
@dougm
Copy link
Member

dougm commented Sep 25, 2018

/assign @bsalamat

@bsalamat this is a cherry pick of PR #68984 which you approved, can you review for release-1.12 ?

bsalamat
bsalamat approved these changes Sep 25, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, dougm, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0ed3388 into kubernetes:release-1.12 Sep 25, 2018
@k82cn
Copy link
Member

k82cn commented Sep 26, 2018

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm left review comments

@bsalamat bsalamat bsalamat approved these changes

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@dougm dougm

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tpepper @cblecker @dougm @k8s-ci-robot @k82cn @bsalamat