add /etc/nsswitch.conf to control plane images #69238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
BenTheElder
force-pushed
the
nsswitch
branch
from
c8cabd4
to
6d0c8af
Compare
|
/sig release |
k8s-ci-robot
added
sig/release
ixdy
reviewed
Sep 28, 2018
build/nsswitch.conf
Outdated
| @@ -0,0 +1 @@ | |||
| hosts: files dns | |||
There was a problem hiding this comment.
no trailing newline?
also I feel like this maybe belongs in a subdir, but I don't know where.
There was a problem hiding this comment.
first is done, don't know what subdir either...
build/BUILD
Outdated
| # This list should roughly match kube::build::get_docker_wrapped_binaries() | ||
| # in build/common.sh. | ||
| DOCKERIZED_BINARIES = { | ||
| "cloud-controller-manager": { | ||
| "base": "@official_busybox//image", | ||
| "base": "busybox-with-nsswitch", |
BenTheElder
force-pushed
the
nsswitch
branch
from
6d0c8af
to
8ffd0b2
Compare
k8s-ci-robot
added
size/S
ixdy
reviewed
Sep 28, 2018
BenTheElder
force-pushed
the
nsswitch
branch
from
8ffd0b2
to
4274c42
Compare
|
/kind bug |
k8s-ci-robot
added
kind/bug
|
hmmm https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69238/pull-kubernetes-verify/108080/#verify-staging-godeps something with godeps flaking... /retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: adds a minimal
/etc/nsswitch.confto control plane images that do not have one, ensuring that they respect /etc/hosts when lookup up hostnamesWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #69195
Special notes for your reviewer: Without this, in some cases we may do unnecessary DNS lookups in EG the API server. This broke my control plane boot due to trying to lookup
localhostRelease note: