New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /etc/nsswitch.conf to control plane images #69238

Merged
merged 1 commit into from Sep 29, 2018

Conversation

Projects
None yet
3 participants
@BenTheElder
Member

BenTheElder commented Sep 28, 2018

What this PR does / why we need it: adds a minimal /etc/nsswitch.conf to control plane images that do not have one, ensuring that they respect /etc/hosts when lookup up hostnames

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #69195

Special notes for your reviewer: Without this, in some cases we may do unnecessary DNS lookups in EG the API server. This broke my control plane boot due to trying to lookup localhost

Release note:

Images for cloud-controller-manager, kube-apiserver, kube-controller-manager, and kube-scheduler now contain a minimal /etc/nsswitch.conf and should respect /etc/hosts for lookups
@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder Sep 28, 2018

Member

/sig release

Member

BenTheElder commented Sep 28, 2018

/sig release

@k8s-ci-robot k8s-ci-robot added sig/release and removed needs-sig labels Sep 28, 2018

@ixdy

lgtm besides minor nits

Show outdated Hide outdated build/nsswitch.conf
Show outdated Hide outdated build/BUILD

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Sep 28, 2018

Show resolved Hide resolved build/BUILD
@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder Sep 29, 2018

Member

/kind bug

Member

BenTheElder commented Sep 29, 2018

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug and removed needs-kind labels Sep 29, 2018

@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@ixdy

ixdy approved these changes Sep 29, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Sep 29, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Sep 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder Sep 29, 2018

Member

/retest

Member

BenTheElder commented Sep 29, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit b1e15b4 into kubernetes:master Sep 29, 2018

18 checks passed

cla/linuxfoundation BenTheElder authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@BenTheElder BenTheElder deleted the BenTheElder:nsswitch branch Sep 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment