Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Opt out of chowning and chmoding from kubectl cp. #69573
What this PR does / why we need it:
This fails in environment where the container runs as root but is not
Before this patch below was the behavior of
After this patch
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
I chose the short flag
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
I spent sometime looking at the tests especially around here:
And I can't seem to find a way to actually exercise the behavior introduced by this PR, I'll am open to ideas, if you have thoughts on how I can actually exercise this feature in the unit test.
Verify input parameters of the
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing