Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
kubeadm: Introduce config print init/join-defaults #69617
What this PR does / why we need it:
In order to improve the UX of kubeadm, it was decided to introduce the
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
I understand what you are doing, but the readability of having a single generic function needs to be broken up a bit.
@rosti sorry for the late review
I think that this PR could be further simplified by adding the "action" parameter to getSupportedAPIObjects and getAllAPIObjectNames (that we can eventually merge since there is no historical objects to manage now)
Then we can have the deprecated print-defaults, print init-defaults and join-defaults insisting on the same code.
@fabriziopandini my first idea was on those lines, but that way, when
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
The full list of commands accepted by this bot can be found here.
The pull request process is described here