Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always set lastTransitionTime when crd condition changes #69655

Merged

Conversation

@CaoShuFeng
Copy link
Member

commented Oct 11, 2018

Fixes: #69654

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

When the status of a CRD Condition changes, it's corresponding `LastTransitionTime` is now updated.
@CaoShuFeng

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2018

/test pull-kubernetes-integration

@nikhita

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

/kind bug
/area custom-resources

/cc @sttts

@nikhita

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

I think it'd be nice to have a release note for this. Something like:

When the status of a CRD Condition changes, it's corresponding `LastTransitionTime` is now updated.
@CaoShuFeng CaoShuFeng force-pushed the CaoShuFeng:Established_lastTransitionTime branch from f664ab7 to df25aef Oct 11, 2018
@CaoShuFeng

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2018

I think it'd be nice to have a release note for this. Something like:

Done.

@nikhita

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

Thanks @CaoShuFeng!

/lgtm

/assign @sttts
for approval

@nikhita

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

/lgtm cancel

It looks good, but let's also add a test for it?

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 11, 2018
@jennybuckley

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2018

/assign @mbohlool

@CaoShuFeng CaoShuFeng force-pushed the CaoShuFeng:Established_lastTransitionTime branch from df25aef to bc8afbd Oct 12, 2018
@liggitt

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

one change needed (and tests updated accordingly), then lgtm

@liggitt liggitt moved this from Triage to Required for GA, in progress in Custom Resource Definitions Apr 24, 2019
@fejta-bot

This comment has been minimized.

Copy link

commented Jul 23, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 22, 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@sttts sttts force-pushed the CaoShuFeng:Established_lastTransitionTime branch from bc8afbd to b035c10 Aug 27, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 27, 2019
@sttts sttts removed the lifecycle/rotten label Aug 27, 2019
@sttts

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

/approve

@sttts sttts added this to the v1.16 milestone Aug 27, 2019
@nikhita

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/lgtm

/assign @liggitt
for approval

@nikhita

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 27, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sttts sttts force-pushed the CaoShuFeng:Established_lastTransitionTime branch from b035c10 to eaf59df Aug 27, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 27, 2019
@nikhita

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 27, 2019
@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CaoShuFeng, liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bcb464d into kubernetes:master Aug 27, 2019
24 checks passed
24 checks passed
cla/linuxfoundation CaoShuFeng authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@liggitt liggitt moved this from Required for GA, in progress to Complete in Custom Resource Definitions Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.