always set lastTransitionTime when crd condition changes

[CaoShuFeng]

Fixes: #69654

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

When the status of a CRD Condition changes, it's corresponding `LastTransitionTime` is now updated.

[CaoShuFeng]

/test pull-kubernetes-integration

[nikhita]

/kind bug
/area custom-resources

/cc @sttts

[nikhita]

I think it'd be nice to have a release note for this. Something like:

When the status of a CRD Condition changes, it's corresponding `LastTransitionTime` is now updated.

[CaoShuFeng]

I think it'd be nice to have a release note for this. Something like:

Done.

[nikhita]

Thanks @CaoShuFeng!

/lgtm

/assign @sttts
for approval

[nikhita]

/lgtm cancel

It looks good, but let's also add a test for it?

kubernetes/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/helpers_test.go

Line 93 in effd009

func TestSetCRDCondition(t *testing.T) {

[jennybuckley]

/assign @mbohlool

[liggitt]

one change needed (and tests updated accordingly), then lgtm

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[sttts]

/approve

[nikhita]

/lgtm

/assign @liggitt
for approval

[nikhita]

/retest

[fejta-bot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[nikhita]

/lgtm

[liggitt]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CaoShuFeng, liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment