Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick for #69694 #69744

Merged
merged 2 commits into from
Oct 13, 2018
Merged

cherrypick for #69694 #69744

merged 2 commits into from
Oct 13, 2018

Conversation

jessfraz
Copy link
Contributor

What this PR does / why we need it: This adds a default for the ProcMount feature and fixes #69647
It is a cherry-pick of #69694

kube-apiserver: fixes `procMount` field incorrectly being marked as required in openapi schema

@jessfraz
fix omitempty on ProcMount
082c543 
Signed-off-by: Jess Frazelle <acidburn@microsoft.com>
(cherry picked from commit 5e63ef0)
@jessfraz
run make update
64a8a76 
Signed-off-by: Jess Frazelle <acidburn@microsoft.com>
(cherry picked from commit ce6f716)
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 12, 2018
@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Oct 12, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 12, 2018
@liggitt
Copy link
Member

liggitt commented Oct 12, 2018

/sig node
/kind bug
/priority critical-urgent
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jessfraz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2018
@liggitt
Copy link
Member

liggitt commented Oct 12, 2018

/assign @feiskyer

@rdrgmnzs rdrgmnzs mentioned this pull request Oct 12, 2018
Merged
@liggitt
Copy link
Member

liggitt commented Oct 12, 2018

/retest

@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5cda1f3 into kubernetes:release-1.12 Oct 13, 2018
@jessfraz jessfraz deleted the cherrypick-69694 branch October 13, 2018 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@janetkuo janetkuo Awaiting requested review from janetkuo

Assignees

@feiskyer feiskyer

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jessfraz @liggitt @k8s-ci-robot @feiskyer