Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos of the 'utilities' #69783

Closed
wants to merge 3 commits into from
Closed

Fix typos of the 'utilities' #69783

wants to merge 3 commits into from

Conversation

mooncak
Copy link
Contributor

@mooncak mooncak commented Oct 14, 2018

What this PR does / why we need it:
Fix typos of the 'utilities':

  1. pkg/kubectl/cmd/taint/utils.go
  2. pkg/util/taints/taints.go

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubectl needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/cli Categorizes an issue or PR as relevant to SIG CLI. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 14, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @mooncak. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mooncak
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nikhita
nikhita reviewed Oct 14, 2018
View reviewed changes
pkg/kubectl/cmd/taint/utils.go
@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

// Package taints implements utilites for working with taints
// Package taints implements utilities for working with taints
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mooncak thanks for the cleanup! Can you also fix this typo in this line:

kubernetes/test/e2e/storage/persistent_volumes-local.go

Line 1293 in d20912c

// Block e2e tests require utilities for writing to block devices (e.g. dd), and nginx has this utilites.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhita it's already merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhita it's already merged.

I don't follow.

nginx has this utilites.

Here it should be s/utilites/utilities

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhita it's already merged.

I don't follow.

nginx has this utilites.

Here it should be s/utilites/utilities

see #69784

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mooncak Can you make the change in #69784 in this PR itself? It's better to combine related cleanups together - easier for review + approval. :)

@nikhita
Copy link
Member

nikhita commented Oct 14, 2018

/kind cleanup

@mooncak Please also squash the commits into a single commit.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 14, 2018
@nikhita nikhita mentioned this pull request Oct 15, 2018
Closed
@mooncak
Copy link
Contributor Author

mooncak commented Oct 16, 2018

/kind cleanup

@mooncak Please also squash the commits into a single commit.

Track this issue by #69888

@mooncak
Copy link
Contributor Author

mooncak commented Oct 16, 2018

Another PR #69888 tracked this issue, close this PR..

@mooncak mooncak closed this Oct 16, 2018
@nikhita nikhita mentioned this pull request Oct 17, 2018
Closed
@mooncak mooncak deleted the fix_typos branch November 3, 2018 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@seans3 seans3 Awaiting requested review from seans3

Assignees
No one assigned
Labels
area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mooncak @k8s-ci-robot @nikhita