Adds label prompt and explanation to pull request template #69837
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,37 @@ | ||
| <!-- Thanks for sending a pull request! Here are some tips for you: | ||
| 1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide | ||
| 2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here: | ||
| https://git.k8s.io/community/contributors/devel/release.md#issue-kind-label | ||
| 3. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews | ||
| 4. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md | ||
| 5. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests | ||
| --> | ||
|
|
||
| **What type of PR is this?** | ||
| > Uncomment only one, leave it on its own line: | ||
| > | ||
| > /kind api-change | ||
| > /kind bug | ||
| > /kind cleanup | ||
| > /kind design | ||
| > /kind documentation | ||
| > /kind failing-test | ||
| > /kind feature | ||
| > /kind flake | ||
|
|
||
| **What this PR does / why we need it**: | ||
|
|
||
| **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: | ||
| Fixes # | ||
|
|
||
| **Special notes for your reviewer**: | ||
|
|
||
| **Does this PR introduce a user-facing change?**: | ||
| <!-- | ||
| If no, just write "NONE". | ||
| If yes, a release note is required: | ||
| Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". | ||
|
There was a problem hiding this comment. @guineveresaenger -- We use the following language in https://git.k8s.io/contributors/guide/release-notes.md:
Does There was a problem hiding this comment. Given @cjwagner's feedback on Slack, looks like the relnote only needs to contain the phrase and the location shouldn't matter, so I'm happy now :) |
||
| 2. | ||
| --> | ||
| ```release-note | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about /kind cleanup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was wondering if it was perhaps too laborious for folks to choose from a long list of labels (esp since the issue template doesn't list them) but I'm happy to add them all.