Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e manifests #69868

Merged
merged 5 commits into from
Oct 30, 2018
Merged

e2e manifests #69868

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1effe0c
e2e framework: UniqueName
pohly Oct 12, 2018
dcbcef1
e2e: simplify gcePD .yaml files
pohly Oct 25, 2018
38efff5
e2e: deploy from manifest files + enhance CSI volume output
pohly Oct 16, 2018
a56c518
e2e CSI: bump all containers to v0.4.1
pohly Oct 26, 2018
248df4a
e2e: update bazel BUILD files
pohly Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
569 changes: 569 additions & 0 deletions test/e2e/framework/create.go
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 10 additions & 0 deletions test/e2e/framework/framework.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"bufio"
"bytes"
"fmt"
"math/rand"
"os"
"strings"
"sync"
Expand Down Expand Up @@ -68,6 +69,11 @@ const (
type Framework struct {
BaseName string

// Set together with creating the ClientSet and the namespace.
// Guaranteed to be unique in the cluster even when running the same
// test multiple times in parallel.
UniqueName string

ClientSet clientset.Interface
KubemarkExternalClusterClientSet clientset.Interface
APIExtensionsClientSet apiextensionsclient.Interface
Expand Down Expand Up @@ -229,6 +235,10 @@ func (f *Framework) BeforeEach() {
} else {
Logf("Skipping waiting for service account")
}
f.UniqueName = f.Namespace.GetName()
} else {
// not guaranteed to be unique, but very likely
f.UniqueName = fmt.Sprintf("%s-%08x", f.BaseName, rand.Int31())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is namespace creation not enabled? And if so, what namespace is used? We have lots of tests that depend on namespace name for generating unique names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The framework supports it. Tests explicitly have to ask for it. I don't know which tests make use of that option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use Namespace.Name and not support parallel drivers tests when it's not set? At least in our official CI, it creates the namespaces per test and we have many other test cases depending on that behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can definitely rely on Namespace.Name and do that in our tests already.

I added this fallback code merely for those tests that might have been written differently. I didn't want to leave f.UniqueName empty in that case, when it isn't that hard to come up with something that serves the same purpose.

}

if TestContext.GatherKubeSystemResourceUsageData != "false" && TestContext.GatherKubeSystemResourceUsageData != "none" {
Expand Down
Loading