-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e manifests #69868
Merged
Merged
e2e manifests #69868
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1effe0c
e2e framework: UniqueName
pohly dcbcef1
e2e: simplify gcePD .yaml files
pohly 38efff5
e2e: deploy from manifest files + enhance CSI volume output
pohly a56c518
e2e CSI: bump all containers to v0.4.1
pohly 248df4a
e2e: update bazel BUILD files
pohly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When is namespace creation not enabled? And if so, what namespace is used? We have lots of tests that depend on namespace name for generating unique names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The framework supports it. Tests explicitly have to ask for it. I don't know which tests make use of that option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just use Namespace.Name and not support parallel drivers tests when it's not set? At least in our official CI, it creates the namespaces per test and we have many other test cases depending on that behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can definitely rely on Namespace.Name and do that in our tests already.
I added this fallback code merely for those tests that might have been written differently. I didn't want to leave f.UniqueName empty in that case, when it isn't that hard to come up with something that serves the same purpose.