Fix service targetPort with string for Windows #70076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone v1.13 |
k8s-ci-robot
added
needs-kind
k8s-ci-robot
added
the
needs-sig
|
/kind bug |
|
/test |
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/milestone v1.13 |
|
/retest |
|
/check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
When service's targetPort is set to port name, then service on Windows doesn't work as expected because winkernel proxier always treat the port as 0.
This PR fixes this by getting the port from endpoints.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #69336 #67827
Special notes for your reviewer:
Note that
hcsshim.AddLoadBalancer()doesn't support endpoints with different ports, so only port from the first endpoint is used.Does this PR introduce a user-facing change?:
/sig windows
/assign @madhanrm @dineshgovindasamy