New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ContinueOnError visitor #70311

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
4 participants
@juanvallejo
Member

juanvallejo commented Oct 26, 2018

/kind bug

Does this PR introduce a user-facing change?:

"kubectl get" no longer exits before printing all of its results if an error is found

Based on the godoc and desired behavior of the ContinueOnError visitor, encountering an error while visiting results should not short-circuit a visitor chain.

This patch replaces existing behavior, which wraps a decorated visitor in a ContinueOnError visitor, with the originally-intended behavior which prevents a DecoratedVisitor list from short-circuiting upon encountering an error.

cc @soltysh @seans3

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Oct 27, 2018

/assign soltysh seans3

@soltysh

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 29, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh

This comment has been minimized.

Contributor

soltysh commented Oct 29, 2018

/kind bug
@juanvallejo mind updating the release notes, b/c that behavior only applies to --continue-on-error flag, not all kubectl get incovations

@k8s-ci-robot k8s-ci-robot added kind/bug and removed needs-kind labels Oct 29, 2018

@k8s-ci-robot k8s-ci-robot merged commit d0a10f0 into kubernetes:master Oct 29, 2018

18 checks passed

cla/linuxfoundation juanvallejo authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@juanvallejo juanvallejo deleted the juanvallejo:jvallejo/fix-continueonerror-visitor branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment