Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ContinueOnError visitor #70311

Merged
merged 1 commit into from
Oct 29, 2018
Merged

fix ContinueOnError visitor #70311

merged 1 commit into from
Oct 29, 2018

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Oct 26, 2018 •
edited
Loading

/kind bug

Does this PR introduce a user-facing change?:

"kubectl get" no longer exits before printing all of its results if an error is found

Based on the godoc and desired behavior of the ContinueOnError visitor, encountering an error while visiting results should not short-circuit a visitor chain.

This patch replaces existing behavior, which wraps a decorated visitor in a ContinueOnError visitor, with the originally-intended behavior which prevents a DecoratedVisitor list from short-circuiting upon encountering an error.

cc @soltysh @seans3

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2018
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 26, 2018
@juanvallejo
Copy link
Contributor Author

/assign soltysh seans3

soltysh
soltysh approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor

soltysh commented Oct 29, 2018

/kind bug
@juanvallejo mind updating the release notes, b/c that behavior only applies to --continue-on-error flag, not all kubectl get incovations

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit d0a10f0 into kubernetes:master Oct 29, 2018
@juanvallejo juanvallejo deleted the jvallejo/fix-continueonerror-visitor branch October 29, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@soltysh soltysh

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juanvallejo @k8s-ci-robot @soltysh @seans3