Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Activate unschedulable pods only if the node became more schedulable #70366
What type of PR is this?
What this PR does / why we need it:
This is a performance optimization for scheduler:
Move unschedulable pods to active queue only if a node's scheduling related properties updated. This PR considers node allocatable, node conditions, node taints, node labels and
Which issue(s) this PR fixes (optional, in
Does this PR introduce a user-facing change?:
Oct 29, 2018
Thanks so much for working on this so quickly. Given that nodes send updates every 10 seconds, in large clusters we receive hundreds of node updates per second. So, it is important that the checks be very quick. That's the main reason that I suggested a couple of changes to make the logic simpler. Of course, simpler logic is easier to maintain as well.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing