New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `audit.k8s.io/v1` as default value of option --audit-webhook-vers… #70476

Merged
merged 1 commit into from Nov 5, 2018

Conversation

@charrywanganthony
Contributor

charrywanganthony commented Oct 31, 2018

…ion and --audit-log-version in release 1.13

kube-apiserver: `--audit-webhook-version` and `--audit-log-version` now default to `audit.k8s.io/v1` if unspecified
@idealhack

This comment has been minimized.

Member

idealhack commented Oct 31, 2018

/ok-to-test

I guess we don't need to include in release 1.13 in the release note?

@mbohlool

This comment has been minimized.

Member

mbohlool commented Nov 1, 2018

@@ -66,7 +66,7 @@ func TestAddFlags(t *testing.T) {
"--audit-log-truncate-enabled=true",
"--audit-log-truncate-max-batch-size=45",
"--audit-log-truncate-max-event-size=44",
"--audit-log-version=audit.k8s.io/v1alpha1",

This comment has been minimized.

@liggitt

liggitt Nov 1, 2018

Member

revert this, this is testing that explicitly setting the flag can override the default

@@ -80,7 +80,7 @@ func TestAddFlags(t *testing.T) {
"--audit-webhook-truncate-max-batch-size=43",
"--audit-webhook-truncate-max-event-size=42",
"--audit-webhook-initial-backoff=2s",
"--audit-webhook-version=audit.k8s.io/v1alpha1",

This comment has been minimized.

@liggitt

liggitt Nov 1, 2018

Member

revert this, this is testing that explicitly setting the flag can override the default

@liggitt

This comment has been minimized.

Member

liggitt commented Nov 1, 2018

one comment about the test, lgtm otherwise

Use `audit.k8s.io/v1` as default value of option --audit-webhook-vers…
…ion and --audit-log-version in release 1.13
@charrywanganthony

This comment has been minimized.

Contributor

charrywanganthony commented Nov 2, 2018

/retest

@charrywanganthony

This comment has been minimized.

Contributor

charrywanganthony commented Nov 2, 2018

/assign @deads2k

@liggitt

This comment has been minimized.

Member

liggitt commented Nov 5, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charrywanganthony, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Member

liggitt commented Nov 5, 2018

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature and removed needs-kind labels Nov 5, 2018

@k8s-ci-robot k8s-ci-robot merged commit 714711e into kubernetes:master Nov 5, 2018

18 checks passed

cla/linuxfoundation charrywanganthony authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment