Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use audit.k8s.io/v1 as default value of option --audit-webhook-vers… #70476

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Use audit.k8s.io/v1 as default value of option --audit-webhook-vers… #70476

merged 1 commit into from
Nov 5, 2018

Conversation

ChiuWang
Copy link
Contributor

@ChiuWang ChiuWang commented Oct 31, 2018 •
edited by liggitt
Loading

…ion and --audit-log-version in release 1.13

kube-apiserver: `--audit-webhook-version` and `--audit-log-version` now default to `audit.k8s.io/v1` if unspecified

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 31, 2018
@idealhack
Copy link
Member

/ok-to-test

I guess we don't need to include in release 1.13 in the release note?

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 31, 2018
@mbohlool
Copy link
Contributor

mbohlool commented Nov 1, 2018

cc @liggitt

liggitt
liggitt reviewed Nov 1, 2018
View reviewed changes
cmd/kube-apiserver/app/options/options_test.go Outdated
@@ -66,7 +66,7 @@ func TestAddFlags(t *testing.T) {
"--audit-log-truncate-enabled=true",
"--audit-log-truncate-max-batch-size=45",
"--audit-log-truncate-max-event-size=44",
"--audit-log-version=audit.k8s.io/v1alpha1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this, this is testing that explicitly setting the flag can override the default

liggitt
liggitt reviewed Nov 1, 2018
View reviewed changes
cmd/kube-apiserver/app/options/options_test.go Outdated
@@ -80,7 +80,7 @@ func TestAddFlags(t *testing.T) {
"--audit-webhook-truncate-max-batch-size=43",
"--audit-webhook-truncate-max-event-size=42",
"--audit-webhook-initial-backoff=2s",
"--audit-webhook-version=audit.k8s.io/v1alpha1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this, this is testing that explicitly setting the flag can override the default

@liggitt
Copy link
Member

liggitt commented Nov 1, 2018

one comment about the test, lgtm otherwise

@liggitt liggitt mentioned this pull request Nov 1, 2018
Closed
Use audit.k8s.io/v1 as default value of option --audit-webhook-vers…
9671a03 
…ion and --audit-log-version in release 1.13
@ChiuWang
Copy link
Contributor Author

ChiuWang commented Nov 2, 2018

/retest

@ChiuWang
Copy link
Contributor Author

ChiuWang commented Nov 2, 2018

/assign @deads2k

@liggitt
Copy link
Member

liggitt commented Nov 5, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charrywanganthony, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2018
@liggitt
Copy link
Member

liggitt commented Nov 5, 2018

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit 714711e into kubernetes:master Nov 5, 2018
szuecs added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request May 2, 2019
@szuecs
hotfix audit events, because our tool does not support audit.k8s.io/v…
05de7b9 
…1 which were introduced in kubernetes/kubernetes#70476

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
@szuecs szuecs mentioned this pull request May 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ChiuWang @idealhack @mbohlool @liggitt @k8s-ci-robot @deads2k