New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add readiness gates in kubectl extended output for pods #70775

Merged
merged 2 commits into from Nov 13, 2018

Conversation

@freehan
Copy link
Member

freehan commented Nov 8, 2018

ref: https://github.com/kubernetes/community/blob/master/keps/sig-network/0007-pod-ready%2B%2B.md

  • add readiness gates column in the output of pods for wide option
  • add readiness gates in pod description
add readiness gates in extended output for pods
@seans3

This comment has been minimized.

Copy link
Contributor

seans3 commented Nov 9, 2018

/cc @soltysh

@k8s-ci-robot k8s-ci-robot requested a review from soltysh Nov 9, 2018

@freehan freehan changed the title add readiness gates column in the output of pods for wide option add readiness gates in kubectl extended output for pods Nov 9, 2018

@freehan freehan force-pushed the freehan:pod-ready-cli branch from ccd2dc7 to 55d88c5 Nov 9, 2018

@seans3

This comment has been minimized.

Copy link
Contributor

seans3 commented Nov 9, 2018

/retest

@juanvallejo

This comment has been minimized.

Copy link
Member

juanvallejo commented Nov 9, 2018

/lgtm

cc @soltysh

@soltysh

soltysh approved these changes Nov 9, 2018

Copy link
Contributor

soltysh left a comment

/lgtm
/approve

@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Nov 9, 2018

/priority backlog

@freehan

This comment has been minimized.

Copy link
Member

freehan commented Nov 12, 2018

/assign lavalamp for approval as the PR need one approver from pkg/registry/OWNERS
FYI, this PR changed one of the unit tests under pkg/registry

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 12, 2018

@freehan: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign lavalamp for approval
FYI, this PR unfortunately changed one of the unit tests under pkg/registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seans3

This comment has been minimized.

Copy link
Contributor

seans3 commented Nov 12, 2018

/cc @lavalamp

@k8s-ci-robot k8s-ci-robot requested a review from lavalamp Nov 12, 2018

@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented Nov 13, 2018

Mechanically this is fine.

Did we do some sort of UI review that shows that this merits living as a top level column?

@seans3

This comment has been minimized.

Copy link
Contributor

seans3 commented Nov 13, 2018

Mechanically this is fine.

Did we do some sort of UI review that shows that this merits living as a top level column?

Yes. This has been on discussed and agreed upon weeks/months ago within SIG CLI.

@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented Nov 13, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 13, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, lavalamp, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 68b4be3 into kubernetes:master Nov 13, 2018

18 checks passed

cla/linuxfoundation freehan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment