Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add readiness gates in kubectl extended output for pods #70775

Merged
merged 2 commits into from
Nov 13, 2018
Merged

add readiness gates in kubectl extended output for pods #70775

merged 2 commits into from
Nov 13, 2018

Conversation

freehan
Copy link
Contributor

@freehan freehan commented Nov 8, 2018 •
edited
Loading

ref: https://github.com/kubernetes/community/blob/master/keps/sig-network/0007-pod-ready%2B%2B.md

  • add readiness gates column in the output of pods for wide option
  • add readiness gates in pod description
add readiness gates in extended output for pods

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 8, 2018
@freehan freehan added this to the v1.13 milestone Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2018
@freehan freehan added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 9, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Nov 9, 2018
@seans3
Copy link
Contributor

seans3 commented Nov 9, 2018

/cc @soltysh

@freehan freehan changed the title add readiness gates column in the output of pods for wide option add readiness gates in kubectl extended output for pods Nov 9, 2018
@seans3
Copy link
Contributor

seans3 commented Nov 9, 2018

/retest

@juanvallejo
Copy link
Contributor

/lgtm

cc @soltysh

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2018
soltysh
soltysh approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh
Copy link
Contributor

soltysh commented Nov 9, 2018 •
edited
Loading

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2018
@freehan
Copy link
Contributor Author

freehan commented Nov 12, 2018 •
edited
Loading

/assign lavalamp for approval as the PR need one approver from pkg/registry/OWNERS
FYI, this PR changed one of the unit tests under pkg/registry

@k8s-ci-robot
Copy link
Contributor

@freehan: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign lavalamp for approval
FYI, this PR unfortunately changed one of the unit tests under pkg/registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seans3
Copy link
Contributor

seans3 commented Nov 12, 2018

/cc @lavalamp

@lavalamp
Copy link
Member

Mechanically this is fine.

Did we do some sort of UI review that shows that this merits living as a top level column?

@seans3
Copy link
Contributor

seans3 commented Nov 13, 2018

Mechanically this is fine.

Did we do some sort of UI review that shows that this merits living as a top level column?

Yes. This has been on discussed and agreed upon weeks/months ago within SIG CLI.

@lavalamp
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, lavalamp, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit 68b4be3 into kubernetes:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@mengqiy mengqiy Awaiting requested review from mengqiy

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@soltysh soltysh

@lavalamp lavalamp

@juanvallejo juanvallejo

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@freehan @seans3 @juanvallejo @soltysh @k8s-ci-robot @lavalamp