-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kubeadm] Update CoreDNS Version #70796
Conversation
@@ -309,7 +309,7 @@ const ( | |||
KubeDNSVersion = "1.14.13" | |||
|
|||
// CoreDNSVersion is the version of CoreDNS to be deployed if it is used | |||
CoreDNSVersion = "1.2.4" | |||
CoreDNSVersion = "1.2.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version in the upgrade tests also need to be changed.
Resolves an issue that has been seen with ExternalName services not resolving.
/lgtm |
/assign @timothysc |
|
/LGTM providing test updates. |
/test pull-kubernetes-bazel-build |
/test pull-kubernetes-e2e-kubeadm-gce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
ping @MrHohn @rajansandeep for final LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Resolves an issue that has been seen with ExternalName services not resolving.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes kubernetes/kubeadm#1222
Does this PR introduce a user-facing change?: