New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of CoreDNS to 1.2.6 #70799

Merged
merged 1 commit into from Nov 16, 2018

Conversation

@rajansandeep
Copy link
Member

rajansandeep commented Nov 8, 2018

What type of PR is this?
/kind bug

What this PR does / why we need it:
Updates the version of CoreDNS to 1.2.6 in kube-up deployments.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CoreDNS is now version 1.2.6
@MrHohn

MrHohn approved these changes Nov 8, 2018

Copy link
Member

MrHohn left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rajansandeep

This comment has been minimized.

Copy link
Member

rajansandeep commented Nov 9, 2018

@MrHohn the pre-submit tests seem to be stuck in "expected" state.

@MrHohn

This comment has been minimized.

Copy link
Member

MrHohn commented Nov 9, 2018

Indeed, let's see if /retest can unblock it.
/retest

@rajansandeep

This comment has been minimized.

Copy link
Member

rajansandeep commented Nov 9, 2018

Seems to have worked. Thank you!

@rajansandeep

This comment has been minimized.

Copy link
Member

rajansandeep commented Nov 9, 2018

/test pull-kubernetes-e2e-gke

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 9, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@rajansandeep

This comment has been minimized.

Copy link
Member

rajansandeep commented Nov 14, 2018

@kubernetes/sig-network-pr-reviews @MrHohn
This needs appropriate labels to merge.

@rajansandeep

This comment has been minimized.

Copy link
Member

rajansandeep commented Nov 14, 2018

/sig network

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Nov 15, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 15, 2018

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Nov 15, 2018

/priority important-soon

@rajansandeep

This comment has been minimized.

Copy link
Member

rajansandeep commented Nov 16, 2018

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 16, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 7f74b3a into kubernetes:master Nov 16, 2018

18 checks passed

cla/linuxfoundation rajansandeep authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment