New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl convert: add deprecation warning for 1.13 #70820

Merged
merged 1 commit into from Nov 10, 2018

Conversation

@seans3
Copy link
Contributor

seans3 commented Nov 8, 2018

  • Adds deprecation warning for kubectl convert
In a future release the kubectl convert command will be deprecated.

/sig cli
/are kubectl
/kind cleanup
/assign

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seans3

This comment has been minimized.

Copy link
Contributor

seans3 commented Nov 8, 2018

@k8s-ci-robot k8s-ci-robot requested review from pwittrock and soltysh Nov 8, 2018

@seans3

This comment has been minimized.

Copy link
Contributor

seans3 commented Nov 8, 2018

/assign @erictune

@soltysh

soltysh approved these changes Nov 9, 2018

Copy link
Contributor

soltysh left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 9, 2018

@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Nov 9, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 9, 2018

@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Nov 9, 2018

/priority important-soon

@k8s-ci-robot k8s-ci-robot merged commit e3ddd85 into kubernetes:master Nov 10, 2018

18 checks passed

cla/linuxfoundation seans3 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@seans3 seans3 deleted the seans3:kubectl-convert-deprecate branch Nov 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment