Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add BoundServiceAccountTokenVolume feature #70831

Merged
merged 1 commit into from Nov 13, 2018
Merged

add BoundServiceAccountTokenVolume feature #70831

merged 1 commit into from Nov 13, 2018

Conversation

mikedanese
Copy link
Member

  • require TokenRequest to be enabled and configured
  • bind ca.crt publisher to this feature rather than to TokenRequest

Begin to implement the plan discussed in #70679

/kind feature
/sig auth

@kubernetes/sig-auth-pr-reviews

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2018
@mikedanese mikedanese force-pushed the securesvcacct branch 2 times, most recently from ddecb3e to e1c56dd Compare November 9, 2018 04:31
@mikedanese mikedanese added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2018
@mikedanese
Copy link
Member Author

/retest

@liggitt liggitt added this to the v1.13 milestone Nov 10, 2018
@mikedanese mikedanese changed the title add SecureServiceAccounTokenVolume feature add BoundServiceAccounTokenVolume feature Nov 12, 2018
@mikedanese
Copy link
Member Author

I filed #70961 and renamed the feature to BoundServiceAccountTokenVolume

@liggitt liggitt changed the title add BoundServiceAccounTokenVolume feature add BoundServiceAccountTokenVolume feature Nov 12, 2018
@mikedanese
add BoundServiceAccountTokenVolume feature
f4ff266 
* require TokenRequest to be enabled and configured
* bind ca.crt publisher to this feature rather than to TokenRequest
@liggitt
Copy link
Member

liggitt commented Nov 13, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2018
@liggitt
Copy link
Member

liggitt commented Nov 13, 2018

/hold

@mikedanese does the alpha CI job specify the flags required for token request? make sure it does that before this merges so the alpha CI e2e doesn't turn red

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2018
@mikedanese
Copy link
Member Author

Fixed in #70850

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit bd2cb5a into kubernetes:master Nov 13, 2018
@mikedanese mikedanese deleted the securesvcacct branch November 13, 2018 17:26
@ChiuWang ChiuWang mentioned this pull request Nov 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikedanese @liggitt @k8s-ci-robot