New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DynamicKubeletConfig from init and join workflow #70849

Merged
merged 1 commit into from Nov 13, 2018

Conversation

@yagonobre
Copy link
Member

yagonobre commented Nov 9, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:
Remove DynamicKubeletConfig from init and join workflow, this also remove the DynamicKubeletConfig feature gate.

kubeadm: deprecate the DynamicKubeletConfig feature gate. The functionality is still accessible by using the kubeadm alpha kubelet enable-dynamic command.

/sig cluster-lifecycle
/priority important-soon
/assign @timothysc @fabriziopandini @neolit123
@kubernetes/sig-cluster-lifecycle-pr-reviews

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 9, 2018

Hi @yagonobre. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 9, 2018

@yagonobre: Reiterating the mentions to trigger a notification:
@kubernetes/sig-cluster-lifecycle-pr-reviews

In response to this:

What type of PR is this?
/kind feature

What this PR does / why we need it:
Remove DynamicKubeletConfig from init and join workflow, this also remove the DynamicKubeletConfig feature gate.

kubeadm: remove DynamicKubeletConfig from init and join workflow, also remove the DynamicKubeletConfig feature gate.

/sig cluster-lifecycle
/priority important-soon
/assign @timothysc @fabriziopandini @neolit123
@kubernetes/sig-cluster-lifecycle-pr-reviews

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yagonobre

This comment has been minimized.

Copy link
Member

yagonobre commented Nov 9, 2018

/remove-kind feature
/kind cleanup

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 9, 2018

@yagonobre @fabriziopandini
i think we should move it to it's new location in the same PR?

@neolit123 neolit123 referenced this pull request Nov 9, 2018

Closed

tracking issue for kubeadm init phases #1163

15 of 17 tasks complete
@yagonobre

This comment has been minimized.

Copy link
Member

yagonobre commented Nov 9, 2018

@neolit123 we already have kubelet config enable-dynamic on alpha cmd

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 9, 2018

we already have kubelet config enable-dynamic on alpha cmd

missed it.
ok then this PR is fine.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 9, 2018

/ok-to-test

@neolit123
Copy link
Member

neolit123 left a comment

LGTM thanks @yagonobre

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 9, 2018

we probably need a release note for the removal of the feature gate, at least.
@fabriziopandini @yagonobre

@yagonobre

This comment has been minimized.

Copy link
Member

yagonobre commented Nov 9, 2018

@neolit123 any suggestion? I'm using kubeadm: remove DynamicKubeletConfig from init and join workflow, also remove the DynamicKubeletConfig feature gate.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 9, 2018

please use this:

kubeadm: deprecate the DynamicKubeletConfig feature gate. The functionality is still accessible by using the kubeadm alpha kubelet enable-dynamic command.

// Auditing is beta in 1.8
Auditing = "Auditing"
)

// InitFeatureGates are the default feature gates for the init command
var InitFeatureGates = FeatureList{
CoreDNS: {FeatureSpec: utilfeature.FeatureSpec{Default: true, PreRelease: utilfeature.GA}},
DynamicKubeletConfig: {FeatureSpec: utilfeature.FeatureSpec{Default: false, PreRelease: utilfeature.Beta}},

This comment has been minimized.

@neolit123

neolit123 Nov 9, 2018

Member

sorry, just realized that we cannot remove it directly given the gate is BETA already.

we have to fist deprecate it and keep it around for 1 release:
https://github.com/kubernetes/website/blob/master/content/en/docs/reference/using-api/deprecation-policy.md#deprecation

i tried to explain that in the last two meetings.

/hold
/assign @timothysc

This comment has been minimized.

@yagonobre

yagonobre Nov 9, 2018

Member

What we will do? Reopen the phase pr and mark the feature gate as deprecated?

This comment has been minimized.

@neolit123

neolit123 Nov 9, 2018

Member

i will leave to the others for further comments.
@luxas @fabriziopandini

@yagonobre

This comment has been minimized.

Copy link
Member

yagonobre commented Nov 9, 2018

@neolit123 done!

@fabriziopandini
Copy link
Contributor

fabriziopandini left a comment

@yagonobre thanks for this PR!
/approve

@neolit123 @timothysc my taking from https://github.com/kubernetes/website/blob/master/content/en/docs/reference/using-api/deprecation-policy.md#deprecation is that we can remove the feature but we should keep the feature gate and give a warning for some time.

As per Lucas comment #70024 (review), my suggestion is to unblock this PR and tackle the feature gate warning thing once for all flags in the upcoming PR.

I opened kubernetes/kubeadm#1226 to track this issue in the milestone.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, yagonobre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yagonobre yagonobre force-pushed the yagonobre:rm-dynamic-kubelet branch from 4b9d010 to b42ef15 Nov 12, 2018

@yagonobre yagonobre force-pushed the yagonobre:rm-dynamic-kubelet branch 2 times, most recently from 2f3a008 to 22a772b Nov 12, 2018

@yagonobre

This comment has been minimized.

Copy link
Member

yagonobre commented Nov 12, 2018

/retest

1 similar comment
@yagonobre

This comment has been minimized.

Copy link
Member

yagonobre commented Nov 12, 2018

/retest

@yagonobre yagonobre force-pushed the yagonobre:rm-dynamic-kubelet branch 2 times, most recently from 91fe778 to eb3ae7e Nov 12, 2018

@fabriziopandini

This comment has been minimized.

Copy link
Contributor

fabriziopandini commented Nov 13, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 13, 2018

@yagonobre yagonobre force-pushed the yagonobre:rm-dynamic-kubelet branch from eb3ae7e to 62c9303 Nov 13, 2018

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 13, 2018

/lgtm
tracking of deprecated FGs in: kubernetes/kubeadm#1226

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 13, 2018

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 13, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 9199025 into kubernetes:master Nov 13, 2018

18 checks passed

cla/linuxfoundation yagonobre authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@yagonobre yagonobre deleted the yagonobre:rm-dynamic-kubelet branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment