Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove DynamicKubeletConfig from init and join workflow #70849
What type of PR is this?
What this PR does / why we need it:
Hi @yagonobre. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
referenced this pull request
Nov 10, 2018
left a comment
@yagonobre thanks for this PR!
@neolit123 @timothysc my taking from https://github.com/kubernetes/website/blob/master/content/en/docs/reference/using-api/deprecation-policy.md#deprecation is that we can remove the feature but we should keep the feature gate and give a warning for some time.
As per Lucas comment #70024 (review), my suggestion is to unblock this PR and tackle the feature gate warning thing once for all flags in the upcoming PR.
I opened kubernetes/kubeadm#1226 to track this issue in the milestone.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing