-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DynamicKubeletConfig from init and join workflow #70849
Conversation
Hi @yagonobre. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@yagonobre: Reiterating the mentions to trigger a notification: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-kind feature |
@yagonobre @fabriziopandini |
@neolit123 we already have |
missed it. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @yagonobre
we probably need a release note for the removal of the feature gate, at least. |
@neolit123 any suggestion? I'm using |
please use this:
|
// Auditing is beta in 1.8 | ||
Auditing = "Auditing" | ||
) | ||
|
||
// InitFeatureGates are the default feature gates for the init command | ||
var InitFeatureGates = FeatureList{ | ||
CoreDNS: {FeatureSpec: utilfeature.FeatureSpec{Default: true, PreRelease: utilfeature.GA}}, | ||
DynamicKubeletConfig: {FeatureSpec: utilfeature.FeatureSpec{Default: false, PreRelease: utilfeature.Beta}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, just realized that we cannot remove it directly given the gate is BETA already.
we have to fist deprecate it and keep it around for 1 release:
https://github.com/kubernetes/website/blob/master/content/en/docs/reference/using-api/deprecation-policy.md#deprecation
i tried to explain that in the last two meetings.
/hold
/assign @timothysc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we will do? Reopen the phase pr and mark the feature gate as deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will leave to the others for further comments.
@luxas @fabriziopandini
@neolit123 done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yagonobre thanks for this PR!
/approve
@neolit123 @timothysc my taking from https://github.com/kubernetes/website/blob/master/content/en/docs/reference/using-api/deprecation-policy.md#deprecation is that we can remove the feature but we should keep the feature gate and give a warning for some time.
As per Lucas comment #70024 (review), my suggestion is to unblock this PR and tackle the feature gate warning thing once for all flags in the upcoming PR.
I opened kubernetes/kubeadm#1226 to track this issue in the milestone.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, yagonobre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4b9d010
to
b42ef15
Compare
2f3a008
to
22a772b
Compare
/retest |
1 similar comment
/retest |
91fe778
to
eb3ae7e
Compare
/milestone v1.13 |
…DynamicKubeletConfig feature gate
eb3ae7e
to
62c9303
Compare
/lgtm |
/hold cancel |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Remove DynamicKubeletConfig from init and join workflow, this also remove the DynamicKubeletConfig feature gate.
/sig cluster-lifecycle
/priority important-soon
/assign @timothysc @fabriziopandini @neolit123
@kubernetes/sig-cluster-lifecycle-pr-reviews