Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Windows Overlay support to Kube Proxy #70896

Merged
merged 5 commits into from Feb 20, 2019

Conversation

ksubrmnn
Copy link
Contributor

@ksubrmnn ksubrmnn commented Nov 9, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR adds support in Kube-proxy for Overlay networks in Windows. Kube-Proxy currently only supports L2Bridge networks on Windows. On Windows, Host Networking Service (HNS) is responsible for ensuring network connectivity. HNS needs to be programmed in a different way for Overlay than L2Bridge.

Specifically, HNS needs additional configuration to allow Cluster IP connectivity. This is reflected in this PR by programming "service VIPs."

Currently HNS supports both DSR and non DSR for loadbalancing. This support is also reflected in this PR by adding support for both.

This PR also adds support for using HNS in V1 and V2. V2 is necessary for DSR and Overlay, but non DSR L2Bridge is supported in both.

Testing:
Basic unit tests for Kube Proxy are added in this PR to check if remote endpoints and loadbalancers are created and accounted for. More testing will follow in subsequent PRs.

Tests were also created to test HNS V1 and V2 implementations that were added in this PR.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
This is an Alpha feature
There is no design doc associated with this feature
Hcsshim was updated to include the RemoteSubnetPolicy API changes

Does this PR introduce a user-facing change?:

Added kube-proxy support for overlay networking and DSR in Windows and new flags for network-name, source-vip, and enable-dsr.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @ksubrmnn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2018
@ksubrmnn ksubrmnn changed the title Overlay dsr Adding Windows Overlay support to Kube Proxy Nov 13, 2018
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 13, 2018
@ksubrmnn
Copy link
Contributor Author

/assign @thockin

@thockin
Copy link
Member

thockin commented Nov 28, 2018

Can you please update the first comment in this PR to include more information? A lot more.

What does this do? Pretend I don't know anything about Windows.

Was there a design doc or KEP?

Is it considered Alpha or Beta or GA?

Where are the tests? That's a LOT of code to add with no tests.

What should the release notes say about this?

I can't do meaningful review of it because I really don't know what it is doing.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 28, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2018
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 4, 2019
@madhanrm
Copy link
Contributor

madhanrm commented Feb 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 4, 2019
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 5, 2019
@madhanrm
Copy link
Contributor

madhanrm commented Feb 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2019
@madhanrm
Copy link
Contributor

madhanrm commented Feb 8, 2019

@thockin can you please take a look at this PR and help us get this merged? We have several follow up PRs on top of this one.

@dineshgovindasamy
Copy link

@thockin following up from the sig/network meeting, Could you please take a look at this PR and provide your feedback or approve the PR?

@ksubrmnn
Copy link
Contributor Author

@thockin I've separated out the Windows only code into commit b724bdb.

You only need to look at the first 3 commits and the last one. I believe you've already looked at the first 3 so only the last one is new and includes the feature flags.

@thockin
Copy link
Member

thockin commented Feb 20, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksubrmnn, madhanrm, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit c06ca11 into kubernetes:master Feb 20, 2019
SIG-Windows automation moved this from In Review to Done (v.1.14) Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants