Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Windows Overlay support to Kube Proxy #70896

Merged
merged 5 commits into from Feb 20, 2019

Conversation

@ksubrmnn
Copy link
Contributor

ksubrmnn commented Nov 9, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR adds support in Kube-proxy for Overlay networks in Windows. Kube-Proxy currently only supports L2Bridge networks on Windows. On Windows, Host Networking Service (HNS) is responsible for ensuring network connectivity. HNS needs to be programmed in a different way for Overlay than L2Bridge.

Specifically, HNS needs additional configuration to allow Cluster IP connectivity. This is reflected in this PR by programming "service VIPs."

Currently HNS supports both DSR and non DSR for loadbalancing. This support is also reflected in this PR by adding support for both.

This PR also adds support for using HNS in V1 and V2. V2 is necessary for DSR and Overlay, but non DSR L2Bridge is supported in both.

Testing:
Basic unit tests for Kube Proxy are added in this PR to check if remote endpoints and loadbalancers are created and accounted for. More testing will follow in subsequent PRs.

Tests were also created to test HNS V1 and V2 implementations that were added in this PR.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
This is an Alpha feature
There is no design doc associated with this feature
Hcsshim was updated to include the RemoteSubnetPolicy API changes

Does this PR introduce a user-facing change?:

Added kube-proxy support for overlay networking and DSR in Windows and new flags for network-name, source-vip, and enable-dsr.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 9, 2018

Hi @ksubrmnn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch from 391d233 to 95a6cbb Nov 10, 2018

@ksubrmnn ksubrmnn changed the title Overlay dsr Adding Windows Overlay support to Kube Proxy Nov 13, 2018

@ksubrmnn

This comment has been minimized.

Copy link
Contributor Author

ksubrmnn commented Nov 27, 2018

/assign @thockin

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Nov 28, 2018

Can you please update the first comment in this PR to include more information? A lot more.

What does this do? Pretend I don't know anything about Windows.

Was there a design doc or KEP?

Is it considered Alpha or Beta or GA?

Where are the tests? That's a LOT of code to add with no tests.

What should the release notes say about this?

I can't do meaningful review of it because I really don't know what it is doing.

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch from 38d10c3 to f9e4a7b Nov 29, 2018

@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/L labels Dec 19, 2018

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch from f8a4f9d to 9bc7db9 Dec 19, 2018

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch from bbe1209 to b223216 Feb 4, 2019

@madhanrm

This comment has been minimized.

Copy link
Contributor

madhanrm commented Feb 4, 2019

/lgtm

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch from b223216 to 6ee37fb Feb 5, 2019

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch from 6ee37fb to c115b5a Feb 5, 2019

@madhanrm

This comment has been minimized.

Copy link
Contributor

madhanrm commented Feb 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 6, 2019

@madhanrm

This comment has been minimized.

Copy link
Contributor

madhanrm commented Feb 8, 2019

@thockin can you please take a look at this PR and help us get this merged? We have several follow up PRs on top of this one.

@dineshgovindasamy

This comment has been minimized.

Copy link

dineshgovindasamy commented Feb 12, 2019

@thockin following up from the sig/network meeting, Could you please take a look at this PR and provide your feedback or approve the PR?

@ksubrmnn

This comment has been minimized.

Copy link
Contributor Author

ksubrmnn commented Feb 19, 2019

@thockin I've separated out the Windows only code into commit b724bdb.

You only need to look at the first 3 commits and the last one. I believe you've already looked at the first 3 so only the last one is new and includes the feature flags.

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Feb 20, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksubrmnn, madhanrm, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c06ca11 into kubernetes:master Feb 20, 2019

16 checks passed

cla/linuxfoundation ksubrmnn authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Context retired without replacement.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

SIG-Windows automation moved this from In Review to Done (v.1.14) Feb 20, 2019

@ksubrmnn ksubrmnn referenced this pull request Feb 27, 2019

Closed

REQUEST: New membership for ksubrmnn #530

6 of 6 tasks complete

@loganhz loganhz referenced this pull request Mar 4, 2019

Open

Windows GA - support windows 1809/2019 #16460

7 of 85 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.