New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Windows Overlay support to Kube Proxy #70896

Open
wants to merge 5 commits into
base: master
from

Conversation

@ksubrmnn
Copy link
Contributor

ksubrmnn commented Nov 9, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR adds support in Kube-proxy for Overlay networks in Windows. Kube-Proxy currently only supports L2Bridge networks on Windows. On Windows, Host Networking Service (HNS) is responsible for ensuring network connectivity. HNS needs to be programmed in a different way for Overlay than L2Bridge.

Specifically, HNS needs additional configuration to allow Cluster IP connectivity. This is reflected in this PR by programming "service VIPs."

Currently HNS supports both DSR and non DSR for loadbalancing. This support is also reflected in this PR by adding support for both.

This PR also adds support for using HNS in V1 and V2. V2 is necessary for DSR and Overlay, but non DSR L2Bridge is supported in both.

Testing:
Basic unit tests for Kube Proxy are added in this PR to check if remote endpoints and loadbalancers are created and accounted for. More testing will follow in subsequent PRs.

Tests were also created to test HNS V1 and V2 implementations that were added in this PR.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
This is an Alpha feature
There is no design doc associated with this feature
Hcsshim was updated to include the RemoteSubnetPolicy API changes

Does this PR introduce a user-facing change?:

Added kube-proxy support for overlay networking and DSR in Windows and new flags for network-name, source-vip, and enable-dsr.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 9, 2018

Hi @ksubrmnn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch from 391d233 to 95a6cbb Nov 10, 2018

@ksubrmnn ksubrmnn changed the title Overlay dsr Adding Windows Overlay support to Kube Proxy Nov 13, 2018

@ksubrmnn

This comment has been minimized.

Copy link
Contributor

ksubrmnn commented Nov 27, 2018

/assign @thockin

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Nov 28, 2018

Can you please update the first comment in this PR to include more information? A lot more.

What does this do? Pretend I don't know anything about Windows.

Was there a design doc or KEP?

Is it considered Alpha or Beta or GA?

Where are the tests? That's a LOT of code to add with no tests.

What should the release notes say about this?

I can't do meaningful review of it because I really don't know what it is doing.

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch from 38d10c3 to f9e4a7b Nov 29, 2018

@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/L labels Dec 19, 2018

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch from f8a4f9d to 9bc7db9 Dec 19, 2018

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch 2 times, most recently from 6e4fad5 to 817f1ee Jan 11, 2019

@PatrickLang PatrickLang added this to Backlog in SIG-Windows Jan 11, 2019

@PatrickLang PatrickLang moved this from Backlog to In Review in SIG-Windows Jan 11, 2019

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch 2 times, most recently from 4f9f7be to dd81618 Jan 11, 2019

Show resolved Hide resolved pkg/proxy/winkernel/hnsV2.go Outdated
@ksubrmnn

This comment has been minimized.

Copy link
Contributor

ksubrmnn commented Jan 18, 2019

@thockin Can you take a look at the first 3 commits please? The rest are Windows related, but the first 3 pertain to vendoring and config changes.

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch 3 times, most recently from b28799c to 62a3644 Jan 18, 2019

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Jan 22, 2019

If it is alpha it should be covered by a feature gate, shouldn't it?

Otherwise looks OK to me (well contained anyway). Will wait for LGTM from @madhanrm and proper relnote. Ping me when ready for final.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 22, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ksubrmnn, madhanrm
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: thockin

If they are not already assigned, you can assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch from 2bb5d47 to 2299896 Jan 22, 2019

@ksubrmnn ksubrmnn force-pushed the ksubrmnn:overlay_dsr branch from 2299896 to 2149ea7 Jan 22, 2019

@ksubrmnn

This comment has been minimized.

Copy link
Contributor

ksubrmnn commented Jan 23, 2019

@thockin Do we still need a feature flag if we are checking to see if the network they are providing Kube Proxy is overlay or not? In Windows, the a network needs to be created before kube-proxy is started. This network's type is checked, and based on that, we program for either l2bridge of overlay. Since we already have this check, maybe a feature flag is not needed? I included a commit that adds it anyway, but let me know if you think it's still necessary.

The same question applies to DSR, which is a new feature added in this PR. This is already default not enabled, and it is toggled on through the enable-dsr flag. As such, I don't think it needs a feature gate.

@madhanrm

This comment has been minimized.

Copy link
Contributor

madhanrm commented Jan 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 23, 2019

@madhanrm

This comment has been minimized.

Copy link
Contributor

madhanrm commented Jan 23, 2019

ping @thockin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment