New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote raw block volume support to beta #71167

Merged
merged 7 commits into from Nov 17, 2018

Conversation

@msau42
Copy link
Member

msau42 commented Nov 17, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:
Picking up #65829 to address last minute concerns.

promote this feature to beta for 1.12 kubernetes/enhancements#351

API is unchanged
Leave all feature gate checks
Enable it by default
e2e tests running in CI

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Raw block volume support is promoted to beta, and enabled by default. This is accessible via the `volumeDevices` container field in pod specs, and the `volumeMode` field in persistent volume and persistent volume claims definitions.
@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Nov 17, 2018

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 17, 2018

/milestone v1.13
/priority critical-urgent

@saad-ali
Copy link
Member

saad-ali left a comment

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 17, 2018

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 17, 2018

Previously reviewed through 9bbf768 in #65829

Last commit lgtm for preserving current behavior when run against the v1 API of a prior version API server

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, msau42, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 17, 2018

tagged prior to freeze
labeling to satisfy tide requirements for freeze per https://kubernetes.slack.com/archives/C2C40FMNF/p1542418440380400

/kind bug

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 17, 2018

/test pull-kubernetes-local-e2e-containerized

@k8s-ci-robot k8s-ci-robot merged commit ec2e767 into kubernetes:master Nov 17, 2018

17 of 18 checks passed

pull-kubernetes-local-e2e-containerized Job triggered.
Details
cla/linuxfoundation msau42 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 17, 2018

@msau42: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized 18453b0 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment