Switch mholt/caddy to use fork due to verify-godeps issue #71178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
needs-sig
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cblecker If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/kubeadm
sig/cluster-lifecycle
cblecker
added
the
priority/critical-urgent
k8s-ci-robot
removed
the
needs-priority
|
/assign @timothysc |
|
/milestone v1.13 |
cblecker
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold Might be quicker to fix upstream. This is still in the back pocket, as it's passing tests. |
k8s-ci-robot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
caddyserver/caddy#2345 introduced a change to master that prevents this dependency from cloning cleanly. As a result, verify-godeps hits an error after it clones master, as it can't checkout a previous commit after cloning.
Until master is fixed, verify-godeps will fail. This is particularly impacting as we gear towards a release. This PR swaps over to use a clone under my username that is exactly 3 commits behind the current master, so that we can checkout back to the same vendored commit.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #71177
Does this PR introduce a user-facing change?: