New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default pv controller and scheduler to immediate mode if volume binding mode is nil #71286
Conversation
/priority critical-urgent |
/test pull-kubernetes-integration |
/assign @MaciekPytel |
I also need to update the scheduler |
/hold cancel |
/lgtm |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, msau42, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is that behavior already implemented in newer versions? Just want to make sure there won't be a regression when upgrading from 1.10 to 1.11+. Also the default is to add a release note, unless it's something like tests or doc change. Even if it's a minor fix for a specific scenario having release note makes it much easier to spot which versions have the fix and which don't. |
This is only an issue when upgrading between 1.9->1.10, when the feature went from alpha to beta. You can have apiservers that are still on 1.9 with the feature off, and controller manager on 1.10 with the feature on. |
Updated the release note |
What type of PR is this?
@kubernetes/sig-storage-bugs
What this PR does / why we need it:
Allow volume binding mode to be nil even if the feature is enabled to handle HA master component skew. The behavior defaults to immediate mode.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: