Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default pv controller and scheduler to immediate mode if volume binding mode is nil #71286

Merged
merged 1 commit into from Dec 10, 2018

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Nov 20, 2018

What type of PR is this?
@kubernetes/sig-storage-bugs

What this PR does / why we need it:
Allow volume binding mode to be nil even if the feature is enabled to handle HA master component skew. The behavior defaults to immediate mode.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes issue where an apiserver on 1.9 and controller-manager on 1.10 can cause volume provisioning and binding to fail.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 20, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 20, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 20, 2018

/test pull-kubernetes-integration

@msau42
Copy link
Member Author

msau42 commented Nov 20, 2018

/assign @MaciekPytel

@msau42
Copy link
Member Author

msau42 commented Nov 20, 2018

I also need to update the scheduler
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 21, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2018
@msau42 msau42 changed the title Default pv controller to immediate mode if volume binding mode is nil Default pv controller and scheduler to immediate mode if volume binding mode is nil Nov 21, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 21, 2018

/assign @jsafrane @wojtek-t

@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2018
@jsafrane
Copy link
Member

/approve

1 similar comment
@wojtek-t
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, msau42, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2018
@MaciekPytel
Copy link
Contributor

Is that behavior already implemented in newer versions? Just want to make sure there won't be a regression when upgrading from 1.10 to 1.11+.

Also the default is to add a release note, unless it's something like tests or doc change. Even if it's a minor fix for a specific scenario having release note makes it much easier to spot which versions have the fix and which don't.

@msau42
Copy link
Member Author

msau42 commented Nov 27, 2018

This is only an issue when upgrading between 1.9->1.10, when the feature went from alpha to beta. You can have apiservers that are still on 1.9 with the feature off, and controller manager on 1.10 with the feature on.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 27, 2018
@msau42
Copy link
Member Author

msau42 commented Nov 27, 2018

Updated the release note

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit 2b1e3d3 into kubernetes:release-1.10 Dec 10, 2018
@msau42 msau42 deleted the release-1.10 branch March 4, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants