Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kube-proxy service abstraction optional #71355

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Make kube-proxy service abstraction optional #71355

merged 3 commits into from
Dec 19, 2018

Conversation

bradhoekstra
Copy link
Contributor

@bradhoekstra bradhoekstra commented Nov 22, 2018 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/0031-20181017-kube-proxy-services-optional.md

Which issue(s) this PR fixes:
Fixes #71354

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

Make kube-proxy service abstraction optional.
Add the 'service.kubernetes.io/service-proxy-name' label to a Service to disable the kube-proxy service proxy implementation.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @bradhoekstra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bradhoekstra
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2018
@bradhoekstra
Copy link
Contributor Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 22, 2018
bradhoekstra
bradhoekstra commented Nov 22, 2018
View reviewed changes
Copy link
Contributor Author

@bradhoekstra bradhoekstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking for a way to test this change. If anyone has any pointers/suggestions that would be appreciated.

cmd/kube-proxy/app/server.go
informerFactory := informers.NewSharedInformerFactory(s.Client, s.ConfigSyncPeriod)
informerFactory := informers.NewSharedInformerFactoryWithOptions(s.Client, s.ConfigSyncPeriod,
informers.WithTweakListOptions(func(options *v1meta.ListOptions) {
options.LabelSelector = "!service.kubernetes.io/service-proxy-name"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to factor out this string to group it with other constants but I didn't find a clear place that I could add this. Any suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The easiest would be in an e2e - we already have some tests that test kube-proxy implementation details. We really need an e2e-suite for kube-proxy that doesn't need all of the kube suite to run.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a precedent for something like pkg/proxy/apis/well_known_labels.go (CF pkg/kubelet/apis/well_known_labels.go and pkg/scheduler/api/well_known_labels.go).

I will accept that as a followup.

@mikedanese mikedanese removed their request for review November 26, 2018 19:30
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2018
@bradhoekstra
Copy link
Contributor Author

/assign @thockin
/hold cancel

I've added an e2e test to cover this feature.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2018
@thockin
Copy link
Member

thockin commented Dec 5, 2018

/retest

@thockin
Copy link
Member

thockin commented Dec 5, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2018
@thockin
Copy link
Member

thockin commented Dec 5, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2018
@bradhoekstra
Copy link
Contributor Author

/retest pull-kubernetes-verify

@bradhoekstra
Copy link
Contributor Author

/test pull-kubernetes-verify

@bradhoekstra
Copy link
Contributor Author

bradhoekstra commented Dec 6, 2018 •
edited
Loading

I fixed the bazel issue. @thockin, can you re-lgtm? Thanks

thockin
thockin reviewed Dec 19, 2018
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

cmd/kube-proxy/app/server.go
informerFactory := informers.NewSharedInformerFactory(s.Client, s.ConfigSyncPeriod)
informerFactory := informers.NewSharedInformerFactoryWithOptions(s.Client, s.ConfigSyncPeriod,
informers.WithTweakListOptions(func(options *v1meta.ListOptions) {
options.LabelSelector = "!service.kubernetes.io/service-proxy-name"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a precedent for something like pkg/proxy/apis/well_known_labels.go (CF pkg/kubelet/apis/well_known_labels.go and pkg/scheduler/api/well_known_labels.go).

I will accept that as a followup.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradhoekstra, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bradhoekstra
Copy link
Contributor Author

/test pull-kubernetes-godeps

@k8s-ci-robot k8s-ci-robot merged commit 7ce7a80 into kubernetes:master Dec 19, 2018
@bradhoekstra bradhoekstra mentioned this pull request Jan 30, 2019
Merged
@wojtek-t wojtek-t mentioned this pull request Feb 13, 2019
Open
@danwinship danwinship mentioned this pull request Sep 10, 2019
Closed
rcarrillocruz added a commit to rcarrillocruz/sdn that referenced this pull request Oct 1, 2019
@rcarrillocruz
WIP Implement kubernetes/kubernetes#71355 in kube-proxy
2248564
rcarrillocruz added a commit to rcarrillocruz/sdn that referenced this pull request Oct 1, 2019
@rcarrillocruz
WIP Implement kubernetes/kubernetes#71355 in kube-proxy
d5fa25d
rcarrillocruz added a commit to rcarrillocruz/sdn that referenced this pull request Oct 1, 2019
@rcarrillocruz
WIP Implement kubernetes/kubernetes#71355 in kube-proxy
ce399a8
This was referenced Aug 31, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@bowei bowei

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement KEP: Make kube-proxy service abstraction optional
4 participants
@bradhoekstra @k8s-ci-robot @thockin @bowei