New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kube-proxy service abstraction optional #71355

Merged
merged 3 commits into from Dec 19, 2018

Conversation

@bradhoekstra
Copy link
Contributor

bradhoekstra commented Nov 22, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/0031-20181017-kube-proxy-services-optional.md

Which issue(s) this PR fixes:
Fixes #71354

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

Make kube-proxy service abstraction optional.
Add the 'service.kubernetes.io/service-proxy-name' label to a Service to disable the kube-proxy service proxy implementation.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 22, 2018

Hi @bradhoekstra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bradhoekstra

This comment has been minimized.

Copy link
Contributor

bradhoekstra commented Nov 22, 2018

/hold

@bradhoekstra

This comment has been minimized.

Copy link
Contributor

bradhoekstra commented Nov 22, 2018

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network and removed needs-sig labels Nov 22, 2018

@bradhoekstra
Copy link
Contributor

bradhoekstra left a comment

I'm looking for a way to test this change. If anyone has any pointers/suggestions that would be appreciated.

informerFactory := informers.NewSharedInformerFactory(s.Client, s.ConfigSyncPeriod)
informerFactory := informers.NewSharedInformerFactoryWithOptions(s.Client, s.ConfigSyncPeriod,
informers.WithTweakListOptions(func(options *v1meta.ListOptions) {
options.LabelSelector = "!service.kubernetes.io/service-proxy-name"

This comment has been minimized.

@bradhoekstra

bradhoekstra Nov 22, 2018

Contributor

I would like to factor out this string to group it with other constants but I didn't find a clear place that I could add this. Any suggestions?

This comment has been minimized.

@thockin

thockin Nov 26, 2018

Member

The easiest would be in an e2e - we already have some tests that test kube-proxy implementation details. We really need an e2e-suite for kube-proxy that doesn't need all of the kube suite to run.

This comment has been minimized.

@thockin

thockin Dec 19, 2018

Member

There's a precedent for something like pkg/proxy/apis/well_known_labels.go (CF pkg/kubelet/apis/well_known_labels.go and pkg/scheduler/api/well_known_labels.go).

I will accept that as a followup.

@mikedanese mikedanese removed their request for review Nov 26, 2018

@bradhoekstra

This comment has been minimized.

Copy link
Contributor

bradhoekstra commented Nov 30, 2018

/assign @thockin
/hold cancel

I've added an e2e test to cover this feature.

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Dec 5, 2018

/retest

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Dec 5, 2018

/ok-to-test

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Dec 5, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 5, 2018

@bradhoekstra

This comment has been minimized.

Copy link
Contributor

bradhoekstra commented Dec 5, 2018

/retest pull-kubernetes-verify

@bradhoekstra

This comment has been minimized.

Copy link
Contributor

bradhoekstra commented Dec 5, 2018

/test pull-kubernetes-verify

@bradhoekstra

This comment has been minimized.

Copy link
Contributor

bradhoekstra commented Dec 6, 2018

I fixed the bazel issue. @thockin, can you re-lgtm? Thanks

@thockin
Copy link
Member

thockin left a comment

/lgtm
/approve

informerFactory := informers.NewSharedInformerFactory(s.Client, s.ConfigSyncPeriod)
informerFactory := informers.NewSharedInformerFactoryWithOptions(s.Client, s.ConfigSyncPeriod,
informers.WithTweakListOptions(func(options *v1meta.ListOptions) {
options.LabelSelector = "!service.kubernetes.io/service-proxy-name"

This comment has been minimized.

@thockin

thockin Dec 19, 2018

Member

There's a precedent for something like pkg/proxy/apis/well_known_labels.go (CF pkg/kubelet/apis/well_known_labels.go and pkg/scheduler/api/well_known_labels.go).

I will accept that as a followup.

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 19, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradhoekstra, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bradhoekstra

This comment has been minimized.

Copy link
Contributor

bradhoekstra commented Dec 19, 2018

/test pull-kubernetes-godeps

@k8s-ci-robot k8s-ci-robot merged commit 7ce7a80 into kubernetes:master Dec 19, 2018

19 checks passed

cla/linuxfoundation bradhoekstra authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment