Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Inconsistent termination message output #71416

Closed
wants to merge 2 commits into from
Closed

[WIP] Inconsistent termination message output #71416

wants to merge 2 commits into from

Conversation

pontiyaraja
Copy link
Contributor

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: This PR to resolve the issue #70990

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): #70990
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/kubelet needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Nov 26, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @pontiyaraja. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pontiyaraja
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vishh

If they are not already assigned, you can assign the PR to them by writing /assign @vishh in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita
Copy link
Member

nikhita commented Nov 26, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2018
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-integration

@pontiyaraja
Copy link
Contributor Author

/work-in-progress

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-verify
/test pull-kubernetes-e2e-kops-aws

@pontiyaraja
Copy link
Contributor Author

/wip

@pontiyaraja
Copy link
Contributor Author

/retest

justinsb
justinsb reviewed Nov 28, 2018
View reviewed changes
Copy link
Member

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got half way through and realized this is likely a WIP?

pkg/kubelet/kuberuntime/kuberuntime_container.go Outdated Show resolved Hide resolved
pkg/kubelet/kuberuntime/logs/logs.go Outdated Show resolved Hide resolved
pkg/kubelet/kuberuntime/logs/logs.go Outdated Show resolved Hide resolved
test/e2e/common/runtime.go Show resolved Hide resolved
@pontiyaraja pontiyaraja changed the title Inconsistent termination message output [WIP] Inconsistent termination message output Nov 29, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2018
@pontiyaraja
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 29, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2018
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-node-e2e

@pontiyaraja pontiyaraja changed the title Inconsistent termination message output [WIP] Inconsistent termination message output Dec 5, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2018
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-node-e2e
/test pull-kubernetes-integration
/test pull-kubernetes-verify

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@pontiyaraja pontiyaraja changed the title [WIP] Inconsistent termination message output Inconsistent termination message output Dec 7, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2018
@pontiyaraja pontiyaraja mentioned this pull request Dec 19, 2018
Closed
6 tasks
@pontiyaraja
Copy link
Contributor Author

/assign @oomichi

@pontiyaraja
Copy link
Contributor Author

/retest

@pontiyaraja
Copy link
Contributor Author

pontiyaraja commented Jan 4, 2019 •
edited

/test pull-kubernetes-local-e2e-containerized

@pontiyaraja
Copy link
Contributor Author

@kubernetes/sig-node-bugs

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 8, 2019
@pontiyaraja pontiyaraja changed the title Inconsistent termination message output [WIP] Inconsistent termination message output Jan 11, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2019
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-node-e2e

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-local-e2e-containerized

@k8s-ci-robot
Copy link
Contributor

@pontiyaraja: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized 71cf0bc link /test pull-kubernetes-local-e2e-containerized
pull-kubernetes-e2e-kops-aws 71cf0bc link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2019
@k8s-ci-robot
Copy link
Contributor

@pontiyaraja: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgdevstack
Copy link
Contributor

/close
xref #70990

@k8s-ci-robot
Copy link
Contributor

@mgdevstack: Closed this PR.

In response to this:

/close
xref #70990

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@changyaowei changyaowei changyaowei left review comments

@k-toyoda-pi k-toyoda-pi k-toyoda-pi left review comments

@MrHohn MrHohn Awaiting requested review from MrHohn

@vishh vishh Awaiting requested review from vishh

Assignees

@oomichi oomichi

Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@pontiyaraja @k8s-ci-robot @nikhita @msau42 @mgdevstack @justinsb @changyaowei @k-toyoda-pi @oomichi