New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent termination message output #71416

Open
wants to merge 1 commit into
base: master
from

Conversation

@pontiyaraja
Contributor

pontiyaraja commented Nov 26, 2018

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: This PR to resolve the issue #70990

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): #70990
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 26, 2018

Hi @pontiyaraja. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Nov 26, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pontiyaraja
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vishh

If they are not already assigned, you can assign the PR to them by writing /assign @vishh in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from MrHohn and vishh Nov 26, 2018

@nikhita

This comment has been minimized.

Member

nikhita commented Nov 26, 2018

/ok-to-test

@pontiyaraja

This comment has been minimized.

Contributor

pontiyaraja commented Nov 26, 2018

/test pull-kubernetes-integration

@pontiyaraja

This comment has been minimized.

Contributor

pontiyaraja commented Nov 26, 2018

/work-in-progress

@pontiyaraja

This comment has been minimized.

Contributor

pontiyaraja commented Nov 27, 2018

/test pull-kubernetes-verify
/test pull-kubernetes-e2e-kops-aws

@pontiyaraja

This comment has been minimized.

Contributor

pontiyaraja commented Nov 27, 2018

/wip

@pontiyaraja

This comment has been minimized.

Contributor

pontiyaraja commented Nov 28, 2018

/retest

@justinsb

Got half way through and realized this is likely a WIP?

Show resolved Hide resolved pkg/kubelet/kuberuntime/kuberuntime_container.go Outdated
Show resolved Hide resolved pkg/kubelet/kuberuntime/logs/logs.go Outdated
Show resolved Hide resolved pkg/kubelet/kuberuntime/logs/logs.go Outdated
Show resolved Hide resolved test/e2e/common/runtime.go

@pontiyaraja pontiyaraja changed the title from Inconsistent termination message output to [WIP] Inconsistent termination message output Nov 29, 2018

@pontiyaraja

This comment has been minimized.

Contributor

pontiyaraja commented Nov 29, 2018

/kind cleanup

@pontiyaraja pontiyaraja force-pushed the pontiyaraja:70990 branch from 4300821 to 9d66181 Dec 4, 2018

@pontiyaraja pontiyaraja changed the title from [WIP] Inconsistent termination message output to Inconsistent termination message output Dec 4, 2018

@msau42

This comment has been minimized.

Member

msau42 commented Dec 5, 2018

/test pull-kubernetes-e2e-gke

@msau42

This comment has been minimized.

Member

msau42 commented Dec 5, 2018

/hold
This is just a test debugging PR and is not meant to be merged

@pontiyaraja

This comment has been minimized.

Contributor

pontiyaraja commented Dec 5, 2018

/test pull-kubernetes-node-e2e

@pontiyaraja pontiyaraja changed the title from Inconsistent termination message output to [WIP] Inconsistent termination message output Dec 5, 2018

@pontiyaraja

This comment has been minimized.

Contributor

pontiyaraja commented Dec 6, 2018

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-node-e2e
/test pull-kubernetes-integration
/test pull-kubernetes-verify

@pontiyaraja

This comment has been minimized.

Contributor

pontiyaraja commented Dec 6, 2018

/test pull-kubernetes-e2e-kops-aws

@pontiyaraja pontiyaraja force-pushed the pontiyaraja:70990 branch from c0d9b67 to 4acbbb4 Dec 6, 2018

@pontiyaraja pontiyaraja force-pushed the pontiyaraja:70990 branch from 4acbbb4 to f5fed40 Dec 7, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Dec 7, 2018

@pontiyaraja: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e f5fed40 link /test pull-kubernetes-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pontiyaraja pontiyaraja changed the title from [WIP] Inconsistent termination message output to Inconsistent termination message output Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment