-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flake with e2e test that checks detach while mount in progress #71429
Fix flake with e2e test that checks detach while mount in progress #71429
Conversation
while root cause is accurate, I need to tweak some other timings here to ensure this does not flake. |
/hold |
/priority critical-urgent |
/test pull-kubernetes-e2e-gce-device-plugin-gpu |
A volume can show up as in-use even before it gets attached to the node.
6fdd66f
to
df88257
Compare
So I have found another problem with this e2e - sometimes a pod can be deleted by e2e even before the kubelet starts mounting it. When this happens, the test will fail because it does not enter code path we are trying to test. To circumvent it, I had to add another sleep after pod creation. This fixes it but still isn't ideal solution. /hold cancel |
@gnufied let me know when this is ready to review. If it is not possible to fix soon, we can consider moving it to flaky. |
@saad-ali it is ready for review, but there is a timing issue that is kinda hard to fix because we don't know state of kubelet from outside. if a pod gets deleted before volume-manager starts mounting it, we run into case where the e2e will not reproduce the bug. I have added a sleep to prevent that and it should lessen that - but it is not a strong guarantee. |
Ack. Ok let's get this merged. If it is still flaky, we can just mark the test flaky. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A volume can show up as in-use even before it gets attached
to the node.
Fixes #71426
/sig storage
/kind bug
cc @nikopen