-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #6812, limit length of load balancer names #7145
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
LGTM. Can be merged as soon as Travis or Shippable are green. |
SGTM. Waiting on Green. |
Resolve #6812, limit length of load balancer names
…sts that were relying on it.
…sts that were relying on it.
Use the first 32 bytes of string ("a"+ service.UID) as ELB's name, thus the length of the name is shorter than the requirement of AWS. Adding a prefix "a" is to satisfy GCE's requiements on ELB's name.