Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #6812, limit length of load balancer names #7145

Merged
merged 1 commit into from
Apr 22, 2015

Conversation

caesarxuchao
Copy link
Member

Use the first 32 bytes of string ("a"+ service.UID) as ELB's name, thus the length of the name is shorter than the requirement of AWS. Adding a prefix "a" is to satisfy GCE's requiements on ELB's name.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ghost ghost added cla: yes and removed cla: no labels Apr 21, 2015
@ghost
Copy link

ghost commented Apr 21, 2015

LGTM. Can be merged as soon as Travis or Shippable are green.

@fabioy fabioy added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2015
@fabioy
Copy link
Contributor

fabioy commented Apr 22, 2015

SGTM. Waiting on Green.

@fabioy fabioy self-assigned this Apr 22, 2015
bgrant0607 added a commit that referenced this pull request Apr 22, 2015
Resolve #6812, limit length of load balancer names
@bgrant0607 bgrant0607 merged commit 1a9c179 into kubernetes:master Apr 22, 2015
a-robinson added a commit to a-robinson/kubernetes that referenced this pull request May 1, 2015
j3ffml added a commit that referenced this pull request May 2, 2015
Revert #7145 now that #7609 is in, and fix the tests that were relying on it
cjcullen pushed a commit to cjcullen/kubernetes that referenced this pull request May 2, 2015
ghost pushed a commit that referenced this pull request May 3, 2015
ghost pushed a commit that referenced this pull request May 3, 2015
Revert "Revert #7145 now that #7609 is in, and fix the tests that were r...
@caesarxuchao caesarxuchao deleted the 6812 branch May 12, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants