New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix issue scheduler cleanup 71867]: Move compatibility_test.go to pkg/scheduler/api #72014
[Fix issue scheduler cleanup 71867]: Move compatibility_test.go to pkg/scheduler/api #72014
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @huynq0911. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @bsalamat |
/ok-to-test Do you mind setting the PR title to what you typed in the description? "Move compatibility_test.go to pkg/scheduler/api." It'll be easier to know what this PR does at a glance. |
I think you need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @bsalamat
@huynq0911 code needs rebase. |
Move compatibility_test.go to pkg/scheduler/api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks, @huynq0911!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsalamat, huynq0911 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup |
/retest |
1 similar comment
/retest |
/test pull-kubernetes-e2e-kops-aws |
What this PR does / why we need it:
Move compatibility_test.go to pkg/scheduler/api.
This file should move to new package named compatibility to prevent error "import cycle not allowed".
And add import algorithmprovider/defaults also to get factory initialization.
Which issue(s) this PR fixes:
Fixes #71867
Special notes for your reviewer:
/ping @misterikkit
Release note::