-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase limit for object size in streaming serializer #72053
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2b5096d
to
886400f
Compare
xref #57073 where this issue was encountered |
Confirmed the limit to be 1.5MB on 3.1+:
|
/lgtm |
/retest Review the full test history for this PR. Silence the bot with an |
…53-upstream-release-1.13 Automated cherry pick of #72053 upstream release 1.13
…53-upstream-release-1.11 Automated cherry pick of #72053 upstream release 1.11
…53-upstream-release-1.12 Automated cherry pick of #72053 upstream release 1.12
Given that apiserver doesn't have validation for object size, and etcd allows for writing objects larger than 1MB (I think 1.5MB is the limit @jpbetz to confirm), we should allow for reading them in the default streaming serializer.
I bumped the limit significantly to also handle situation where we write protobuf to etcd and we watch jsons which are visibly better (it doesn't guarantee it will always work, but it at least leave some slack so that can be possible).
@kubernetes/sig-api-machinery-bugs