Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang to 1.10.7 (CVE-2018-16875) #72072

Merged
merged 1 commit into from Dec 19, 2018
Merged

Bump golang to 1.10.7 (CVE-2018-16875) #72072

merged 1 commit into from Dec 19, 2018

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Dec 15, 2018 •
edited by cblecker

What type of PR is this?
/kind bug
/kind cleanup

What this PR does / why we need it:
x-ref #72032 for release-1.12.

Does this PR introduce a user-facing change?:

Update to use go1.10.7 with fix for CVE-2018-16875

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 15, 2018
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 15, 2018
@ixdy
Copy link
Member Author

ixdy commented Dec 15, 2018

/assign @feiskyer

working on building the cross-build image now

@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2018
@ixdy
Copy link
Member Author

ixdy commented Dec 15, 2018

(holding because go1.10.6 introduced a regression, and so we need to update to go1.10.7 instead.)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2018
@ixdy ixdy changed the title Bump golang to 1.10.6 (CVE-2018-16875) Bump golang to 1.10.7 (CVE-2018-16875) Dec 15, 2018
@ixdy
Copy link
Member Author

ixdy commented Dec 18, 2018

/retest

@ixdy
Copy link
Member Author

ixdy commented Dec 18, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2018
@cblecker
Copy link
Member

/lgtm
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 19, 2018
@cblecker cblecker added this to the v1.12 milestone Dec 19, 2018
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 19, 2018
@feiskyer
Copy link
Member

cherry pick approved.

@k8s-ci-robot k8s-ci-robot merged commit af105e4 into kubernetes:release-1.12 Dec 19, 2018
@yue9944882 yue9944882 mentioned this pull request Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag Awaiting requested review from mkumatag

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@feiskyer feiskyer

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ixdy @cblecker @k8s-ci-robot @feiskyer