Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition when joining nodes #72151

Closed
wants to merge 1 commit into from
Closed

Fix race condition when joining nodes #72151

wants to merge 1 commit into from

Commits on Dec 18, 2018

  1. Fix race condition when joining nodes 

    Despite we were checking for the kubelet kubeconfig file to be present, the
kubelet first writes this file and then the certificates the kubeconfig file
refers to. This represents a race condition in kubeadm in which when we confirm
that the kubelet's kubeconfig file is present we continue creating a clientset
out of it. However, the clientset creation will ensure that the certificates the
kubeconfig file refers to exist on the filesystem.

To fix this problem, not only wait for the kubelet's kubeconfig file to be
present, but also ensure that we can create a clientset ouf of it on our polling
process, while we wait for the kubelet to have performed the TLS bootstrap.

(cherry picked from commit a31c160463d8ed76b6a627e8ed879d72f79d9e08)
    @ereslibre
    ereslibre committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    763e40d View commit details
    Browse the repository at this point in the history