call createValidation before rollback. Fixes #72256

[jhrv]

What type of PR is this?
/kind bug
/sig apps
/sig api-machinery

What this PR does / why we need it:
Ensures validation for rollback requests

Which issue(s) this PR fixes:

Fixes #72256

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

`deployments/rollback` is now passed through validation/admission controllers

[k8s-ci-robot]

Hi @jhrv. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yue9944882]

validating rollback here makes sense (i suppose?). but wiring into REST explicitly looks odd. should we
probably plumb it as a deployments' UPDATE request instead of a CREATE against deployment/rollback

@kubernetes/sig-api-machinery-misc

kubernetes/pkg/registry/apps/deployment/storage/storage.go

Line 203 in d257ee9

err = r.store.Storage.GuaranteedUpdate(ctx, dKey, &apps.Deployment{}, false, nil, storage.SimpleUpdate(func(obj runtime.Object) (runtime.Object, error) {

/hold

[liggitt]

should we
probably plumb it as a deployments' UPDATE request instead of a CREATE against deployment/rollback

No, it is a post of a rollback resource. the create verb and rollback subresource are correct

/remove-sig api-machinery

[yue9944882]

LGTM please squash

/hold cancel

[jhrv]

/test pull-kubernetes-e2e-gce-device-plugin-gpu

[liggitt]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrv, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/registry/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jhrv]

/test pull-kubernetes-e2e-gce

[jhrv]

/test pull-kubernetes-e2e-gce