Using size ranges for e2e storage drivers and tests

[srmocher]

What type of PR is this?
/kind feature
/sig storage

What this PR does / why we need it:
Removes hardcoded sizes for volumes in tests and unifies the way sizes (or rather ranges) are defined for both the storage test drivers and the tests themselves. Both components specify a range of size to test (or in the case of the driver define what size range it supports). The intersection of the two ranges (the test and the driver's) are taken and the minimum of the result is chosen as the resource claim size.

Tests specify the size range as a property of TestPattern (is this the right way?). I'm not fully familiar with the size constraints on each storager driver yet (and in the tests - I've set some static values now, so added TODOs to remove them).

In the tests, we use getSizeRangesIntersection method and pass in the range from the TestPattern instance and the driver instance and take the intersection.

Which issue(s) this PR fixes:

Fixes #72080

Special notes for your reviewer:
I'm unfamiliar with the parameters to be set for each driver and the tests themselves (compared to the static values existing currently). Happy to know any pointers on setting these parameters.

Does this PR introduce a user-facing change?:
NONE

NONE

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @srmocher. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[srmocher]

/check-cla

[justaugustus]

/check-cla
/ok-to-test

[srmocher]

@mkimuram Could you PTAL? I've updated the code per your comments.
I'm working on getting the CLA signed (issues with Linux ID).

[mkimuram]

@srmocher

Thank you for your fix. I confirmed that my comments are reflected perfectly.
So, getSizeRangesIntersection's logic looks good to me.

While I reviewed this PR again, I started to think that it would be more useful
if the SupportedSizeRange for testsuites are defined in testsuites themselves,
instead of in testpatterns. Because SupportedSizeRange will depend more on
testsuites than testpatterns, and testsuites share testpatterns, as a result,
testpatterns which have size range inside might not be reusable by testsuites
that support different size range.

Could you consider moving it from testpattern to testsuite?

[srmocher]

@mkimuram Sure, will update per your suggestion.

[oomichi]

/retest

[srmocher]

Apologies for the late turnaround, I will push in rest of the fixes shortly.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: srmocher
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mrhohn

If they are not already assigned, you can assign the PR to them by writing /assign @mrhohn in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[srmocher]

/retest

[k8s-ci-robot]

@srmocher: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-node-e2e	54574cf	link	/test pull-kubernetes-node-e2e
pull-kubernetes-e2e-gce	54574cf	link	/test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

@srmocher: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.