Update examples/storm for v1beta3 #7231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcbroussard
force-pushed
the
storm-example
branch
2 times, most recently
from
8f7a8e7
to
e6c362e
Compare
| @@ -155,16 +155,16 @@ before and after creating the ReplicationController. | |||
|
|
|||
| ## tl;dr | |||
|
|
|||
| ```kubectl create -f zookeeper.json``` | |||
| ```kubectl create -f v1beta3/zookeeper.json``` | |||
There was a problem hiding this comment.
These changes in this file are not required anymore.
Please revert.
|
LGTM, modulo one comment |
bcbroussard
force-pushed
the
storm-example
branch
from
e6c362e
to
6b27aa2
Compare
|
@nikhiljindal fixed |
|
Thanks! Lgtm. |
nikhiljindal
added
the
lgtm
nikhiljindal
added a commit
that referenced
this pull request
Apr 24, 2015
Update examples/storm for v1beta3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small part of #6584.