Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: fix golint warnings in package_validator #72399

Merged
merged 1 commit into from
Dec 28, 2018
Merged

kubeadm: fix golint warnings in package_validator #72399

merged 1 commit into from
Dec 28, 2018

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Dec 28, 2018

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fixed the following golint warnigns:

  • package_validator.go:68:1: receiver name should not be an underscore, omit the name if it is unused
  • package_validator.go:89:1: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"
  • package_validator.go:96:1: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"
  • package_validator.go:119:1: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 28, 2018
@bart0sh
Copy link
Contributor Author

bart0sh commented Dec 28, 2018

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 28, 2018
@bart0sh
Copy link
Contributor Author

bart0sh commented Dec 28, 2018

/cc @neolit123

@bart0sh
kubeadm: fix golint warnings in package_validator
60fc0bf 
Fixed the following golint warnigns:
 - package_validator.go:68:1: receiver name should not be an underscore, omit the name if it is unused
 - package_validator.go:89:1: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"
 - package_validator.go:96:1: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"
 - package_validator.go:119:1: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self"
@bart0sh bart0sh force-pushed the PR0049-kubeadm-app-util-system-fix-golint-warnings branch from 5d69f3d to 60fc0bf Compare December 28, 2018 11:38
@bart0sh
Copy link
Contributor Author

bart0sh commented Dec 28, 2018

/test pull-kubernetes-kubemark-e2e-gce-big
/test pull-kubernetes-e2e-gce-100-performance

yagonobre
yagonobre approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bart0sh
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2018
fabriziopandini
fabriziopandini approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bart0sh thanks for this cleanup!
/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit 2cc92a0 into kubernetes:master Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini approved these changes

@yagonobre yagonobre yagonobre approved these changes

@dixudx dixudx Awaiting requested review from dixudx

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@fabriziopandini fabriziopandini

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bart0sh @k8s-ci-robot @fabriziopandini @yagonobre