Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #72361 upstream release 1.13 #72426

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Automated cherry pick of #72361 upstream release 1.13 #72426

merged 1 commit into from
Jan 5, 2019

Conversation

lbernail
Copy link
Contributor

Cherry pick of #72361 on release-1.13.

#72361 : [kube-proxy/ipvs] Protect Netlink calls with a mutex

Does this PR introduce a user-facing change?:

Fix race condition introduced by graceful termination which can lead to a deadlock in kube-proxy

/sig network
/area ipvs
/kind bug

/assign @m1093782566

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. sig/network Categorizes an issue or PR as relevant to SIG Network. area/ipvs kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 29, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @lbernail. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 29, 2018
@lbernail lbernail mentioned this pull request Dec 29, 2018
Closed
@lbernail lbernail changed the title [kube-proxy/ipvs] Protect Netlink calls with a mutex Automated cherry pick of #72361 upstream release 1.13 Dec 29, 2018
@tpepper
Copy link
Member

tpepper commented Jan 2, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2019
@m1093782566
Copy link
Contributor

/priority important-soon

/retest

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 3, 2019
@m1093782566
Copy link
Contributor

/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernail, m1093782566

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2019
@lbernail
Copy link
Contributor Author

lbernail commented Jan 3, 2019

/test pull-kubernetes-verify

3 similar comments
@m1093782566
Copy link
Contributor

/test pull-kubernetes-verify

@lbernail
Copy link
Contributor Author

lbernail commented Jan 4, 2019

/test pull-kubernetes-verify

@lbernail
Copy link
Contributor Author

lbernail commented Jan 4, 2019

/test pull-kubernetes-verify

@lbernail
Copy link
Contributor Author

lbernail commented Jan 4, 2019

/retest

@tpepper
Copy link
Member

tpepper commented Jan 4, 2019

/retest

This pull-kubernetes-verify should pass now that #72530 has merged on release-1.13 branch.

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit d2285a6 into kubernetes:release-1.13 Jan 5, 2019
@foxyriver foxyriver mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1093782566 m1093782566 Awaiting requested review from m1093782566

@thockin thockin Awaiting requested review from thockin

Assignees

@m1093782566 m1093782566

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lbernail @k8s-ci-robot @tpepper @m1093782566