Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove executable file permission from OWNERS files #72525

Merged
merged 1 commit into from Feb 15, 2019
Merged

Remove executable file permission from OWNERS files #72525

merged 1 commit into from Feb 15, 2019

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Jan 3, 2019

There's actually a number of these, so I'm sending a few PRs grouping them thematically.

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 3, 2019
@justinsb justinsb mentioned this pull request Jan 3, 2019
Merged
@k8s-ci-robot k8s-ci-robot added area/apiserver area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 3, 2019
@justinsb justinsb mentioned this pull request Jan 3, 2019
Closed
@justinsb justinsb added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 4, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 4, 2019
@justinsb
Copy link
Member Author

justinsb commented Jan 4, 2019

/retest

@oomichi
Copy link
Member

oomichi commented Jan 7, 2019

/test pull-kubernetes-local-e2e-containerized

@justinsb justinsb force-pushed the owners_should_not_be_executable branch from 76cd843 to dd19b92 Compare January 12, 2019 00:43
@oomichi
Copy link
Member

oomichi commented Jan 25, 2019

/retest

@oomichi
Copy link
Member

oomichi commented Jan 25, 2019

It is reasonable to change permissions of OWNERS files which are unnecessary to be executable :-)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2019
@oomichi
Copy link
Member

oomichi commented Jan 26, 2019

/test pull-kubernetes-local-e2e-containerized

@liggitt
Copy link
Member

liggitt commented Feb 15, 2019

I am in favor of not executing the OWNERS

/retest
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 808f2cf into kubernetes:master Feb 15, 2019
hiddeco pushed a commit to hiddeco/kubernetes that referenced this pull request Apr 6, 2020
@k8s-ci-robot
Merge pull request kubernetes#72525 from justinsb/owners_should_not_b…
26f3af3 
…e_executable

Remove executable file permission from OWNERS files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-robinson a-robinson Awaiting requested review from a-robinson

@abrarshivani abrarshivani Awaiting requested review from abrarshivani

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @oomichi @liggitt @k8s-ci-robot