New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move VolumeSnapshotDataSource feature gate check from validation #72666

Merged
merged 1 commit into from Jan 9, 2019

Conversation

@rajathagasthya
Copy link
Contributor

rajathagasthya commented Jan 8, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Moves feature-gate checking of VolumeSnapshotDataSource out of validation into the strategy utility methods, and avoids dropping data on update if the existing PVC Spec already used DataSource. Adds unit test for the strategy utility method and updates validation test.
Which issue(s) this PR fixes:
xref #72651

Does this PR introduce a user-facing change?:

The `spec.dataSource` field is now dropped during creation of PersistentVolumeClaim objects unless the `VolumeSnapshotDataSource` feature gate is enabled.

/sig api-machinery
/sig storage

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 8, 2019

Hi @rajathagasthya. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from jbeda and jsafrane Jan 8, 2019

@rajathagasthya

This comment has been minimized.

Copy link
Contributor Author

rajathagasthya commented Jan 8, 2019

/assign @liggitt

@sbezverk

This comment has been minimized.

Copy link
Contributor

sbezverk commented Jan 8, 2019

/ok-to-test

@rajathagasthya rajathagasthya force-pushed the rajathagasthya:pvc-72651 branch from 414f9d3 to bbdce5c Jan 8, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 8, 2019

FYI, please don't reference the issue in the commit message like rajathagasthya@414f9d3, github spams issues mercilessly any time the commit is pushed anywhere

@rajathagasthya

This comment has been minimized.

Copy link
Contributor Author

rajathagasthya commented Jan 8, 2019

Ugh, sorry for the notification spam!

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 8, 2019

@rajathagasthya rajathagasthya force-pushed the rajathagasthya:pvc-72651 branch from bbdce5c to 88abcb7 Jan 8, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 8, 2019

/approve

will leave to @kubernetes/sig-storage-api-reviews for lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, rajathagasthya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rajathagasthya

This comment has been minimized.

Copy link
Contributor Author

rajathagasthya commented Jan 8, 2019

/test pull-kubernetes-integration

1 similar comment
@rajathagasthya

This comment has been minimized.

Copy link
Contributor Author

rajathagasthya commented Jan 8, 2019

/test pull-kubernetes-integration

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jan 8, 2019

/lgtm

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 8, 2019

/retest

1 similar comment
@rajathagasthya

This comment has been minimized.

Copy link
Contributor Author

rajathagasthya commented Jan 8, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 8, 2019

#71696 failure

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 8, 2019

ridiculous
/retest

@rajathagasthya

This comment has been minimized.

Copy link
Contributor Author

rajathagasthya commented Jan 8, 2019

:/
/retest

@k8s-ci-robot k8s-ci-robot merged commit 3035edc into kubernetes:master Jan 9, 2019

19 checks passed

cla/linuxfoundation rajathagasthya authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@rajathagasthya rajathagasthya deleted the rajathagasthya:pvc-72651 branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment