Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move VolumeSnapshotDataSource feature gate check from validation #72666

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Move VolumeSnapshotDataSource feature gate check from validation #72666

merged 1 commit into from
Jan 9, 2019

Conversation

rajathagasthya
Copy link
Contributor

@rajathagasthya rajathagasthya commented Jan 8, 2019 •
edited by liggitt
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Moves feature-gate checking of VolumeSnapshotDataSource out of validation into the strategy utility methods, and avoids dropping data on update if the existing PVC Spec already used DataSource. Adds unit test for the strategy utility method and updates validation test.
Which issue(s) this PR fixes:
xref #72651

Does this PR introduce a user-facing change?:

The `spec.dataSource` field is now dropped during creation of PersistentVolumeClaim objects unless the `VolumeSnapshotDataSource` feature gate is enabled.

/sig api-machinery
/sig storage

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @rajathagasthya. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jan 8, 2019
@rajathagasthya
Copy link
Contributor Author

/assign @liggitt

@liggitt liggitt mentioned this pull request Jan 8, 2019
Closed
12 tasks
@sbezverk
Copy link
Contributor

sbezverk commented Jan 8, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2019
@liggitt
Copy link
Member

liggitt commented Jan 8, 2019

FYI, please don't reference the issue in the commit message like rajathagasthya@414f9d3, github spams issues mercilessly any time the commit is pushed anywhere

@rajathagasthya
Copy link
Contributor Author

Ugh, sorry for the notification spam!

@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 8, 2019
@liggitt
Copy link
Member

liggitt commented Jan 8, 2019

cc @msau42
@kubernetes/sig-storage-pr-reviews

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 8, 2019
@liggitt
Copy link
Member

liggitt commented Jan 8, 2019

/approve

will leave to @kubernetes/sig-storage-api-reviews for lgtm

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, rajathagasthya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@rajathagasthya
Copy link
Contributor Author

/test pull-kubernetes-integration

1 similar comment
@rajathagasthya
Copy link
Contributor Author

/test pull-kubernetes-integration

@msau42
Copy link
Member

msau42 commented Jan 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@liggitt
Copy link
Member

liggitt commented Jan 8, 2019

/retest

1 similar comment
@rajathagasthya
Copy link
Contributor Author

/retest

@liggitt
Copy link
Member

liggitt commented Jan 8, 2019

#71696 failure

@liggitt
Copy link
Member

liggitt commented Jan 8, 2019

ridiculous
/retest

@rajathagasthya
Copy link
Contributor Author

:/
/retest

@k8s-ci-robot k8s-ci-robot merged commit 3035edc into kubernetes:master Jan 9, 2019
@rajathagasthya rajathagasthya deleted the pvc-72651 branch January 9, 2019 05:26
@xing-yang xing-yang mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@jbeda jbeda Awaiting requested review from jbeda

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@liggitt liggitt

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rajathagasthya @k8s-ci-robot @sbezverk @liggitt @msau42