New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kube-proxy PodSecurityPolicy RoleBinding namespace #72761

Merged
merged 1 commit into from Jan 11, 2019

Conversation

@tallclair
Copy link
Member

tallclair commented Jan 10, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
kube-proxy's PodSecurityPolicy binding was accidentally created in the default namespace rather than kube-system

Does this PR introduce a user-facing change?:

Fix kube-proxy PodSecurityPolicy binding on GCE & GKE. This was only an issue when running kube-proxy as a DaemonSet, with PodSecurityPolicy enabled.

/sig gce
/priority important-soon

@tallclair

This comment has been minimized.

Copy link
Member Author

tallclair commented Jan 10, 2019

/assign @cadmuxe

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 10, 2019

@tallclair: GitHub didn't allow me to assign the following users: cadmuxe.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @cadmuxe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from gmarek and jszczepkowski Jan 10, 2019

@tallclair

This comment has been minimized.

Copy link
Member Author

tallclair commented Jan 10, 2019

/assign @bowei

@krmayankk

This comment has been minimized.

Copy link
Contributor

krmayankk commented Jan 10, 2019

/lgtm

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Jan 10, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 10, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 10, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@tallclair

This comment has been minimized.

Copy link
Member Author

tallclair commented Jan 10, 2019

/retest

1 similar comment
@tallclair

This comment has been minimized.

Copy link
Member Author

tallclair commented Jan 10, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 10, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 06af89c into kubernetes:master Jan 11, 2019

18 checks passed

cla/linuxfoundation tallclair authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

k8s-ci-robot added a commit that referenced this pull request Jan 11, 2019

Merge pull request #72834 from tallclair/automated-cherry-pick-of-#72…
…761-upstream-release-1.11

Automated cherry pick of #72761 upstream release 1.11

k8s-ci-robot added a commit that referenced this pull request Jan 14, 2019

Merge pull request #72835 from tallclair/automated-cherry-pick-of-#72…
…761-upstream-release-1.12

Automated cherry pick of #72761 upstream release 1.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment