Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint failures on handlers/negotiation #73094

Merged
merged 1 commit into from Feb 20, 2019
Merged

Fix golint failures on handlers/negotiation #73094

merged 1 commit into from Feb 20, 2019

Conversation

oomichi
Copy link
Member

@oomichi oomichi commented Jan 18, 2019 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This fixes golint failures on k8s.io/apiserver/pkg/endpoints/handlers/negotiation/negotiate.go.
DefaultEndpointRestrictions is only used in the module, so this renames it to defaultEndpointRestrictions.

Special notes for your reviewer:

ref: #68026

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 18, 2019
@oomichi
Copy link
Member Author

oomichi commented Jan 18, 2019

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 18, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 18, 2019
neolit123
neolit123 approved these changes Jan 20, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/priority important-longterm
/lgtm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 20, 2019
@fedebongio
Copy link
Contributor

/assign @cheftako

@oomichi
Copy link
Member Author

oomichi commented Feb 20, 2019

@liggitt Could you take a look at this?

liggitt
liggitt reviewed Feb 20, 2019
View reviewed changes
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/negotiation/negotiate.go Outdated
@@ -133,7 +133,7 @@ type EndpointRestrictions interface {
AllowsStreamSchema(schema string) bool
}

var DefaultEndpointRestrictions = emptyEndpointRestrictions{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document rather than unexporting

@liggitt
Copy link
Member

liggitt commented Feb 20, 2019

DefaultEndpointRestrictions is only used in the module, so this renames it to defaultEndpointRestrictions.

k8s.io/apiserver is a library... we don't know where that is used

@oomichi
Copy link
Member Author

oomichi commented Feb 20, 2019

@liggitt

DefaultEndpointRestrictions is only used in the module, so this renames it to defaultEndpointRestrictions.

k8s.io/apiserver is a library... we don't know where that is used

OK, let me revert it.

Fix golint failures on handlers/negotiation
302ec98 
DefaultEndpointRestrictions is only used in the module,
so this renames it to defaultEndpointRestrictions.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2019
@liggitt
Copy link
Member

liggitt commented Feb 20, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2019
@oomichi
Copy link
Member Author

oomichi commented Feb 20, 2019

@liggitt Thanks for your review again :-)

@oomichi
Copy link
Member Author

oomichi commented Feb 20, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 61b676a into kubernetes:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@neolit123 neolit123 neolit123 approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@neolit123 neolit123

@cheftako cheftako

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@oomichi @fedebongio @liggitt @k8s-ci-robot @neolit123 @cheftako